Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memcpy's trailing null-termination #48

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix: memcpy's trailing null-termination #48

merged 3 commits into from
Jun 21, 2022

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented Jun 21, 2022 •
edited
Loading

Issue number and link

Describe your changes

memcpy treats binary data so it must not add trailing NULL byte.

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@laysakura laysakura mentioned this pull request Jun 21, 2022
Closed
@laysakura laysakura merged commit 39dfc71 into main Jun 21, 2022
@laysakura laysakura deleted the fix/memcpy-trailing-null branch June 21, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@laysakura