Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go get currently fails to download dnscontrol #757

Closed
robotmay opened this issue Jun 2, 2020 · 10 comments
Closed

go get currently fails to download dnscontrol #757

robotmay opened this issue Jun 2, 2020 · 10 comments

Comments

@robotmay
Copy link

robotmay commented Jun 2, 2020

Haven't seen any other reference to this so far, but this is currently happening to me on both my CI and my local machine:

$ go get github.com/StackExchange/dnscontrol                                                                                   
# github.com/StackExchange/dnscontrol/vendor/github.com/mittwald/go-powerdns
../../../.go/src/github.com/StackExchange/dnscontrol/vendor/github.com/mittwald/go-powerdns/client.go:58:21: cannot use hc (type *"github.com/StackExchange/dnscontrol/vendor/github.com/mittwald/go-powerdns/pdnshttp".Client) as type *"github.com/mittwald/go-powerdns/pdnshttp".Client in argument to zones.New

This seems to imply a breaking change upstream but I haven't had a chance to look into it properly yet.

@tlimoncelli
Copy link
Contributor

CC: @jpbede

I'm seeing the same thing for fresh clones. My existing repo is fine.

@jpbede
Copy link
Contributor

jpbede commented Jun 2, 2020

I will have a look at this later on.

@jpbede
Copy link
Contributor

jpbede commented Jun 2, 2020

It seams to me that you have already fixed that @tlimoncelli ?

@tlimoncelli
Copy link
Contributor

Umm... I'm not sure if I fixed it.

While investigating I spotted a problem with .gitignore and I fixed that. ("zones" was ignored, not "/zones", which lead to part of github.com/mittwald/go-powerdns not being vendored.

Does that fix the problem for everyone?

I still get the error if I unset GOPATH but that might be something funny in my environment.

@jpbede
Copy link
Contributor

jpbede commented Jun 2, 2020

Hmm i can't reproduce it anymore after your .gitignore and go mod tidy fix

@tlimoncelli
Copy link
Contributor

@robotmay Can you confirm?

@robotmay
Copy link
Author

robotmay commented Jun 2, 2020

@tlimoncelli Still getting it on my local machine. Is there anything I'd need to do to clear a cache of some sort?

@tlimoncelli
Copy link
Contributor

Hmm.... the ~/pkg directory is a cache. You can remove it, but I don't think that's related to this problem.

What's your GOPATH variable set to?

@robotmay
Copy link
Author

robotmay commented Jun 2, 2020 via email

@robotmay
Copy link
Author

robotmay commented Jun 3, 2020

@tlimoncelli, @jpbede Looks to be solved on my CI 👍 Thanks for the quick fix! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants