From e02dfe759116ed113c6a9c78971adb7ab3a1f0c6 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Thu, 3 Oct 2024 01:12:25 -0500 Subject: [PATCH] correct comment about git submodules --- BUILD | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/BUILD b/BUILD index 25c87e41c7..8a365a257e 100644 --- a/BUILD +++ b/BUILD @@ -109,8 +109,11 @@ shell_command( tools=["cp"], # execution_dependencies allows pants to invalidate the output # of this command if the .gitmodules file changes (for example: - # if a submodule gets updated to a different commit). - # Theoretically, nothing else should modify .git/modules/. + # if a submodule gets updated to a different repo). + # Sadly this does not get invalidated if the submodule commit + # is updated. In our case, that should be rare. To work around + # If you update a submodule, + # this, kill the `pantsd` process after updating a submodule. execution_dependencies=[":gitmodules"], output_dependencies=[":gitmodules"], output_directories=[".git/modules"],