Skip to content

Commit c668b2e

Browse files
olivernostoolivernosto
authored
Merge pull request #603 from Stackla/ref/remove-duplication-and-redundant-styles
ref: Remove redundant, duplicate styles and remove storypage widget as its not in use.
2 parents 1ead8de + 93dc8b5 commit c668b2e

23 files changed

+89
-1223
lines changed

‎README.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ The repository includes multiple pre-built widget templates:
230230
| **Waterfall** | Vertical scrolling infinite feed | Lazy loading, infinite scroll |
231231
| **Quadrant** | Four-quadrant display | Sectioned content areas |
232232
| **Storyline** | Linear story progression | Sequential content display |
233-
| **Storypage** | Full-page stories | Immersive story experience |
234233
| **Shortvideo** | Video-focused widget | Video playback, mobile-optimized |
235234
| **Nightfall** | Dark-themed widget | Night mode styling |
236235
| **Blankcanvas** | Starter template | Minimal starting point for custom widgets |

‎tests/e2e/widgets/storypage.spec.ts‎

Lines changed: 0 additions & 3 deletions
This file was deleted.

‎widgets/nightfall/_components.scss‎

Lines changed: 2 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@use "./expanded-tiles";
2+
13
#nosto-ugc-container {
24
time-phrase {
35
display: var(--timephrase-display-inline);
@@ -32,86 +34,4 @@
3234
height: 33px;
3335
}
3436
}
35-
}
36-
37-
expanded-tiles {
38-
--expanded-tiles-background: #000;
39-
40-
ugc-products {
41-
.stacklapopup-products-item-price {
42-
--product-price-font-color: #fff;
43-
}
44-
45-
.stacklapopup-products-item-title {
46-
--product-title-font-color: #fff;
47-
}
48-
49-
.stacklapopup-products-item-description {
50-
--product-description-font-color: #fff;
51-
52-
scrollbar-color: white black !important;
53-
}
54-
55-
.recommendations-text {
56-
color: #fff !important;
57-
}
58-
59-
add-to-cart {
60-
.ugc-add-to-cart-colorpicker-text * {
61-
color: white !important;
62-
}
63-
64-
.ugc-add-to-cart-colorpicker-text {
65-
color: white !important;
66-
}
67-
68-
.ugc-add-to-cart-other-variant-selector {
69-
color: white !important;
70-
}
71-
72-
.ugc-add-to-cart-sizepicker-btn[selected="true"] {
73-
border: 1px solid white !important;
74-
background-color: white !important;
75-
76-
span {
77-
color: black !important;
78-
}
79-
}
80-
81-
#variant-container {
82-
p {
83-
color: white !important;
84-
}
85-
86-
p span {
87-
color: white !important;
88-
}
89-
90-
color: white !important;
91-
}
92-
93-
.ugc-add-to-cart-colorpicker-ring span {
94-
&::after {
95-
background-color: white !important;
96-
}
97-
}
98-
99-
.ugc-add-to-cart-sizepicker {
100-
margin-top: 10px;
101-
102-
}
103-
104-
.ugc-add-to-cart-sizepicker-btn {
105-
background-color: black !important;
106-
}
107-
}
108-
}
109-
}
110-
111-
expanded-tiles tile-content {
112-
width: 100%;
113-
114-
.user-handle, .user-link {
115-
color: white;
116-
}
11737
}

‎widgets/nightfall/_expanded-tiles.scss‎

Lines changed: 82 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
1+
2+
expanded-tiles {
3+
--expanded-tiles-background: #000;
4+
5+
ugc-products {
6+
.stacklapopup-products-item-price {
7+
--product-price-font-color: #fff;
8+
}
9+
10+
.stacklapopup-products-item-title {
11+
--product-title-font-color: #fff;
12+
}
13+
14+
.stacklapopup-products-item-description {
15+
--product-description-font-color: #fff;
16+
17+
scrollbar-color: white black !important;
18+
}
19+
20+
.recommendations-text {
21+
color: #fff !important;
22+
}
23+
24+
add-to-cart {
25+
.ugc-add-to-cart-colorpicker-text * {
26+
color: white !important;
27+
}
28+
29+
.ugc-add-to-cart-colorpicker-text {
30+
color: white !important;
31+
}
32+
33+
.ugc-add-to-cart-other-variant-selector {
34+
color: white !important;
35+
}
36+
37+
.ugc-add-to-cart-sizepicker-btn[selected="true"] {
38+
border: 1px solid white !important;
39+
background-color: white !important;
40+
41+
span {
42+
color: black !important;
43+
}
44+
}
45+
46+
#variant-container {
47+
p {
48+
color: white !important;
49+
}
50+
51+
p span {
52+
color: white !important;
53+
}
54+
55+
color: white !important;
56+
}
57+
58+
.ugc-add-to-cart-colorpicker-ring span {
59+
&::after {
60+
background-color: white !important;
61+
}
62+
}
63+
64+
.ugc-add-to-cart-sizepicker {
65+
margin-top: 10px;
66+
67+
}
68+
69+
.ugc-add-to-cart-sizepicker-btn {
70+
background-color: black !important;
71+
}
72+
}
73+
}
74+
}
75+
76+
expanded-tiles tile-content {
77+
width: 100%;
78+
79+
.user-handle, .user-link {
80+
color: white;
81+
}
82+
}

‎widgets/shortvideo/_icon-sections-override.scss‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,3 @@
33
.shortvideo-inline {
44
@include is.icon-sections-styles;
55
}
6-
7-
expanded-tiles {
8-
@include is.icon-sections-styles {
9-
.icon-section {
10-
bottom: 0;
11-
}
12-
13-
&:has(tile-content:not(:empty)) {
14-
.icon-section {
15-
height: calc(100% - 75px);
16-
}
17-
}
18-
}
19-
}

‎widgets/shortvideo/_styles.scss‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
@use "@styles/templates/tags";
1616

1717
// Custom styles for shortvideo - note: uses overrides instead of standard icon-sections and tile-content
18-
.shortvideo-inline,
19-
expanded-tiles {
18+
.shortvideo-inline {
2019
@include sicon.shopspot-icon-styles;
2120
@include tphrase.time-phrase-styles;
2221
@include smenu.share-menu-styles;

‎widgets/shortvideo/_tile-content-override.scss‎

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2,32 +2,4 @@
22

33
.shortvideo-inline {
44
@include tc.tile-content-styles;
5-
}
6-
7-
expanded-tiles {
8-
@include tc.tile-content-styles {
9-
.panel-inactive {
10-
tile-content {
11-
width: 100%;
12-
place-self: flex-end center;
13-
grid-row: span 2;
14-
margin-bottom: 20%;
15-
16-
.tile-content-wrapper .user-info {
17-
gap: 20px;
18-
19-
.user-link .user-name {
20-
color: #4a4a4a;
21-
font-size: 20px;
22-
}
23-
24-
.avatar-wrapper img {
25-
width: 100px;
26-
height: 100px;
27-
opacity: 0.3;
28-
}
29-
}
30-
}
31-
}
32-
}
33-
}
5+
}

‎widgets/starter-project/_styles.scss‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
@use "@styles/partials/icon-sections" as is;
1515
@use "@styles/partials/expanded-swiper" as es;
1616

17-
.grid-inline,
18-
expanded-tiles {
17+
.grid-inline {
1918
@include is.icon-sections-styles;
2019
@include sicon.shopspot-icon-styles;
2120
@include tphrase.time-phrase-styles;

‎widgets/storyline/_icon-sections-override.scss‎

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,4 @@
22

33
.story-inline {
44
@include is.icon-sections-styles;
5-
}
6-
7-
expanded-tiles {
8-
@include is.icon-sections-styles {
9-
.icon-section {
10-
bottom: 0;
11-
}
12-
13-
&:has(tile-content:not(:empty)) {
14-
.icon-section {
15-
height: calc(100% - 75px);
16-
}
17-
}
18-
}
19-
}
5+
}

‎widgets/storyline/_styles.scss‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ html {
2020
}
2121

2222
.story-inline,
23-
.carousel-inline,
24-
expanded-tiles {
23+
.carousel-inline {
2524
@include sicon.shopspot-icon-styles;
2625
@include tphrase.time-phrase-styles;
2726
@include smenu.share-menu-styles;

0 commit comments

Comments
 (0)