Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve keyboard dismiss
♻️ Current situation & Problem
This PR addresses the issues described in #16 where keyboard dismiss would accidentally hit other buttons in the UI and was not able to handle differing submit labels.
💡 Proposed solution
This PR rewrites the
dismissKeyboard
method to cover all currently defined SubmitLabels and employs some heuristic to cover the case where a new submit label is added without our knowledge.Further, this PR proposes to remove the code handling the "swift to type" tutorial (explained here #16 (comment)). I found in my testing that even on completely erased simulator devices this tutorial doesn't pop up anymore. Consequentially, I couldn't verify an implementation that would work in that case. I don't have information that verifies my theory that this popup isn't there anymore for simulator devices, but propose that we tackle this once we can reproduce this popup again. The current implementation produces way more false inputs than it handles the actual problem.
⚙️ Release Notes
dismissKeyboard()
method.Done
orContinue
buttons.➕ Additional Information
Related PRs
--
Testing
Test were updated and extended.
Reviewer Nudging
Code changes should be minimal.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: