Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XCTAssertThrowsErrorAsync #22

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Add XCTAssertThrowsErrorAsync #22

merged 10 commits into from
Jun 27, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jun 26, 2024

Add XCTAssertThrowsErrorAsync

♻️ Current situation & Problem

This PR adds a async version of the XCTAssertThrowsError(_:_:file:line:_:) method.

This method was originally introduced in SpeziBluetooth but was now found to be useful as well in SpeziDevices. Therefore, there is a need to have this available as a reusable implementation.

⚙️ Release Notes

  • Add XCTAssertThrowsErrorAsync(_:_:file:line:_:) method.

📚 Documentation

New interfaces were documented. Additionally the documentation catalog was restructured to provide a bit more overview of supported types.

✅ Testing

Minimal testing.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg requested a review from PSchmiedmayer June 26, 2024 19:28
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you @Supereg!

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jun 27, 2024
@Supereg
Copy link
Member Author

Supereg commented Jun 27, 2024

@PSchmiedmayer could you set the CodeCov token in the repository secrets. I currently do not have permissions for this repo.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the codecov token; updated the permissions for you and also added the token. Just started a re-run of the GitHub Action.

CITATION.cff Show resolved Hide resolved
@Supereg Supereg merged commit 69eae1a into main Jun 27, 2024
9 checks passed
@Supereg Supereg deleted the feature/xctassert-throws-async branch June 27, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants