Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve App Deletion on VisionOS and Swift 6 #26

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 30, 2024

Improve App Deletion on VisionOS and Swift 6

♻️ Current situation & Problem

This PR improves app deletion on the visionOS platform. Further, we introduce a new delete(app:) version that doesn't launch the application. This is useful if you want to delete the app as a teardown procedure of your application. Instead of deleting the application before your test runs you can delete the application after test that perform state changes on the application.

This feature enables the Swift 6 language mode.

⚙️ Release Notes

  • Added delete(app:) extension
  • Improved app deletion on visionOS
  • Swift 6

📚 Documentation

Updated new interfaces.

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.76%. Comparing base (aad6c16) to head (41ba71c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...stExtensions/XCUIApplication+DeleteAndLaunch.swift 82.61% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   87.68%   84.76%   -2.91%     
==========================================
  Files          10       10              
  Lines         357      328      -29     
==========================================
- Hits          313      278      -35     
- Misses         44       50       +6     
Flag Coverage Δ
84.76% <82.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...stExtensions/XCUIApplication+DeleteAndLaunch.swift 82.86% <82.61%> (-5.90%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad6c16...41ba71c. Read the comment docs.

@Supereg Supereg self-assigned this Oct 17, 2024
@Supereg Supereg added the enhancement New feature or request label Oct 17, 2024
@PSchmiedmayer PSchmiedmayer merged commit 5379d70 into main Oct 17, 2024
10 of 11 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/app-delete-improvements branch October 17, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants