-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile warnings #56
base: main
Are you sure you want to change the base?
Conversation
6fec88b
to
684ea1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @ZardenSawtooth! I've added a few comments. Feel free to follow up with any questions you have.
cc: @PSchmiedmayer
src/components/Navbar/Navbar.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const getSublabelText = (): string => { | ||
return props.item.extension?.find((x) => x.url === IExtentionType.sublabel)?.valueMarkdown || ''; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be some code referencing this helper function that is currently commented out. If this function is to be removed, I would also recommend removing the commented out code that is referencing it.
const [isMarkdownActivated, setIsMarkdownActivated] = React.useState<boolean>(!!props.item._text); | ||
const [isMarkdownActivated] = React.useState<boolean>(!!props.item._text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are removing the function that allows us to set this state variable, what is the purpose of keeping the state variable? Can we remove it all together and refactor the code referencing it?
Fixed several compile warnings
♻️ Current situation & Problem
Fixed the following compile warnings to maintain a cleaner compile window.
✅ Testing
Ensured that the compile warnings are gone.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: