Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/v24.02.1 #123

Merged
merged 19 commits into from
Mar 29, 2024
Merged

Update/v24.02.1 #123

merged 19 commits into from
Mar 29, 2024

Conversation

Dominion5254
Copy link
Collaborator

  • Update lightning to 24.02.1 - Release Notes
  • Add Experimental 'Splicing' config option. Closes [feat] Add Splicing Support #122
  • Replace archived 'Rebalance' plugin with 'Sling'
  • Remove archived 'Summary' plugin
  • Fix WT-Client bug
  • Add action to rescan the blockchain from a specified blockheight or depth

@Dominion5254 Dominion5254 self-assigned this Mar 20, 2024
"splicing": {
type: "boolean",
name: "Splicing",
description: "Enables support for the splicing protocol (bolt #863), allowing both parties to dynamically adjust the size a channel. These changes can be built interactively using PSBT and combined with other channel actions including dual fund, additional channel splices, or generic transaction activity. The operations will be bundled into a single transaction. The channel will remain active while awaiting splice confirmation, however you can only spend the smaller of the prior channel balance and the new one. <b>Default: False</b>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Enables support for the splicing protocol (bolt #863), allowing both parties to dynamically adjust the size a channel. These changes can be built interactively using PSBT and combined with other channel actions including dual fund, additional channel splices, or generic transaction activity. The operations will be bundled into a single transaction. The channel will remain active while awaiting splice confirmation, however you can only spend the smaller of the prior channel balance and the new one. <b>Default: False</b>",
description: "Enables support for the splicing protocol (BOLT #863), allowing both parties to dynamically adjust the size a channel. These changes can be built interactively using PSBT and combined with other channel actions including dual fund, additional channel splices, or generic transaction activity. The operations will be bundled into a single transaction. The channel will remain active while awaiting splice confirmation, however you can only spend the smaller of the prior channel balances and not the new one. <b>Default: Disabled</b>",

I think this is what was meant in the last sentence, does it make sense to you?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description I had was pulled directly from the CLN documentation. The documentation description makes sense to me.

During the period where the splice is awaiting confirmation, the channel being spliced allows spending the smaller of the pre-splice or post-splice balance. Limiting the spend to the smaller of the two ensures that the sender is never able to spend more than the channel would allow in either a pre or post spliced state. i.e. if an existing channel with 2mm sats of outbound were awaiting confirmation for a splice down to only 1mm sats of outbound, during the period of the splice awaiting confirmation, the user would be be able to spend a max of 1mm sats (the "new" balance).

I'm good with switching the default description from False to Disabled and have commited the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it was from the docs, but some of their descriptions have minor errors and typos. Want to make sure you understand the change in the final sentence

scripts/procedures/getConfig.ts Outdated Show resolved Hide resolved
@Dominion5254 Dominion5254 merged commit fbbad85 into master Mar 29, 2024
@Dominion5254 Dominion5254 deleted the update/v24.02 branch March 29, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Add Splicing Support
2 participants