From 69bbf3c4b9393b95249bc75cdad5fead14a7145e Mon Sep 17 00:00:00 2001 From: "Jose Manuel (Ito)" Date: Thu, 12 Dec 2024 12:52:18 -0500 Subject: [PATCH] chore(limit): modify as well (#334) * chore(html): update the submission --- frontend/jupyter/cypress/e2e/form-page.cy.ts | 6 +++--- .../form/form-new/form-cpu-ram/form-cpu-ram.component.html | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/frontend/jupyter/cypress/e2e/form-page.cy.ts b/frontend/jupyter/cypress/e2e/form-page.cy.ts index 932f8d7b..b5e80078 100644 --- a/frontend/jupyter/cypress/e2e/form-page.cy.ts +++ b/frontend/jupyter/cypress/e2e/form-page.cy.ts @@ -125,13 +125,13 @@ describe('New notebook form', () => { cy.get('[data-cy-advanced-options-button]').click(); cy.get('[data-cy-form-input="cpu"]').find('input').clear(); // minimum value - cy.get('[data-cy-form-input="cpu"]').find('input').type('0.1'); + cy.get('[data-cy-form-input="cpu"]').find('input').type('0.01'); cy.get('[data-cy-form-input="cpu"]') .find('input') .should('have.class', 'ng-invalid'); cy.get('[data-cy-form-input="cpu"]') .find('mat-error') - .should('have.text', 'Specify at least 0.5 CPUs'); + .should('have.text', 'Specify at least 0.1 CPUs'); cy.get('[data-cy-form-input="cpu"]').find('input').clear(); // maximum value cy.get('[data-cy-form-input="cpu"]').find('input').type('40.0'); @@ -166,7 +166,7 @@ describe('New notebook form', () => { .should('have.class', 'ng-invalid'); cy.get('[data-cy-form-input="memory"]') .find('mat-error') - .should('have.text', 'Specify at least 1Gi of memory'); + .should('have.text', 'Specify at least 0.5Gi of memory'); cy.get('[data-cy-form-input="memory"]').find('input').clear(); // maximum value cy.get('[data-cy-form-input="memory"]').find('input').type('90.0'); diff --git a/frontend/jupyter/src/app/pages/form/form-new/form-cpu-ram/form-cpu-ram.component.html b/frontend/jupyter/src/app/pages/form/form-new/form-cpu-ram/form-cpu-ram.component.html index 781aeeda..1d0d8d9e 100644 --- a/frontend/jupyter/src/app/pages/form/form-new/form-cpu-ram/form-cpu-ram.component.html +++ b/frontend/jupyter/src/app/pages/form/form-new/form-cpu-ram/form-cpu-ram.component.html @@ -17,7 +17,7 @@ [attr.disabled]="readonlySpecs ? '' : null" matInput type="number" - min="0.5" + min="0.1" step="0.1" formControlName="cpu" [errorStateMatcher]="matcher" @@ -38,7 +38,7 @@ [attr.disabled]="readonlySpecs ? '' : null" matInput type="number" - min="1" + min="0.5" step="0.1" formControlName="memory" [errorStateMatcher]="matcher"