-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Wwise detection to account for Godot plugin libraries and new Unity library #853
base: main
Are you sure you want to change the base?
Conversation
Updated SDK.Wwise.txt to account for godot 4.x projects (libwwise.windows.teamplate_release.dll) and Godot 3.x projects (WwiseGDNative.dll)
WwiseGDNative is for Godot 3.x games while libwwise.template is for Godot 4.x games
…'t using wwise on godot
(lib)WwiseGDNative is for Godot 3.x games, while libwwise.(version).template_(release/debug).(dll/so) is for godot 4.x games
After running changed rules in this pull request (this bot only tests rules.ini changes): Changed technologies: SDK.Wwise 2012 apps still match. These apps now match: (13) 1707220 1786010 1965810 2065530 2118940 2283470 2407540 2422440 2429640 2512930 3179920 3227630 3240600 Please confirm that all these changed apps are correct. |
I can confirm that these changed apps all use Wwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's only 1 app that's using (based on what you said) Godot 4 & wwise that's not really enough to edit that rule to match these for now
Let's only keep the godot 3 version
I would also like to say that 2118940 is a Godot game (Godot 3.x), as is 3179920 (Godot 4.x), since to my knowledge only the Godot wwise plugins have the libraries named like that |
How many Godot 4.x games using Wwise must there be in order for those to be matched? The file for the 4.x plugin is from the same plugin as the 3.x extension, only updated. This plugin has also been put in a directory made by the Godot Foundation (https://github.com/godot-sdk-integrations). |
5 to 10 apps (that are unique (demo & game itself count as 1), with 10 being preferable to not have too many edge case |
So I presume that Chicken Fall Prologue is being counted as a separate game here rather than a demo (with Chicken Fall and Chicken Fall Prologue both having demos). Fine, I'll hope that more Godot 4 games use Wwise in the future |
Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
…r some reason Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't appreciate you removing Linux suport, but whatever
AkSoundEngine.dll is now called AkUnitySoundEngine.dll in newer versions of the wwise integration
It is now called AkUnitySoundEngine.dll
There's no use in keeping the linux version when it doesn't help to detect more games |
apologies, I closed the pull request hoping that it wouldn't put my Unity commits into here. I cannot review without approving the changes btw |
SteamDB app page links to a few games using this
Runa & the Chaikurú Legacy: https://steamdb.info/app/2283470/ (depot showing the library in the files: https://steamdb.info/depot/2283472/)
Brief explanation of the change
Godot uses an unofficial but semi officially endorsed plugin to add Wwise to its games. However, the plugin's library file is different from the standard AkSoundEngine.dll. I have added the Godot version for both Godot 3.x and Godot 4.x to rules.ini and the test types folder. I did not account for WaapiGDNative.dll/so, but WWiseGDNative.dll/so should be enough. I don't know if this works so I would like someone with more knowledge of regex to see if what I typed works.