Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Wwise detection to account for Godot plugin libraries and new Unity library #853

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

MonstoBusta
Copy link

SteamDB app page links to a few games using this

Runa & the Chaikurú Legacy: https://steamdb.info/app/2283470/ (depot showing the library in the files: https://steamdb.info/depot/2283472/)

Brief explanation of the change

Godot uses an unofficial but semi officially endorsed plugin to add Wwise to its games. However, the plugin's library file is different from the standard AkSoundEngine.dll. I have added the Godot version for both Godot 3.x and Godot 4.x to rules.ini and the test types folder. I did not account for WaapiGDNative.dll/so, but WWiseGDNative.dll/so should be enough. I don't know if this works so I would like someone with more knowledge of regex to see if what I typed works.

Updated SDK.Wwise.txt to account for godot 4.x projects (libwwise.windows.teamplate_release.dll) and Godot 3.x projects (WwiseGDNative.dll)
WwiseGDNative is for Godot 3.x games while libwwise.template is for Godot 4.x games
(lib)WwiseGDNative is for Godot 3.x games, while libwwise.(version).template_(release/debug).(dll/so) is for godot 4.x games
@SteamDB-Tracker
Copy link
Member

After running changed rules in this pull request (this bot only tests rules.ini changes):

Changed technologies: SDK.Wwise

2012 apps still match.

These apps now match: (13) 1707220 1786010 1965810 2065530 2118940 2283470 2407540 2422440 2429640 2512930 3179920 3227630 3240600

Please confirm that all these changed apps are correct.

@MonstoBusta
Copy link
Author

I can confirm that these changed apps all use Wwise.

Copy link
Collaborator

@Lifeismana Lifeismana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only 1 app that's using (based on what you said) Godot 4 & wwise that's not really enough to edit that rule to match these for now
Let's only keep the godot 3 version

tests/types/SDK.Wwise.txt Outdated Show resolved Hide resolved
tests/types/_NonMatchingTests.txt Outdated Show resolved Hide resolved
rules.ini Outdated Show resolved Hide resolved
@MonstoBusta
Copy link
Author

I would also like to say that 2118940 is a Godot game (Godot 3.x), as is 3179920 (Godot 4.x), since to my knowledge only the Godot wwise plugins have the libraries named like that

@MonstoBusta
Copy link
Author

There's only 1 app that's using (based on what you said) Godot 4 & wwise that's not really enough to edit that rule to match these for now Let's only keep the godot 3 version

How many Godot 4.x games using Wwise must there be in order for those to be matched? The file for the 4.x plugin is from the same plugin as the 3.x extension, only updated. This plugin has also been put in a directory made by the Godot Foundation (https://github.com/godot-sdk-integrations).

@Lifeismana
Copy link
Collaborator

5 to 10 apps (that are unique (demo & game itself count as 1), with 10 being preferable to not have too many edge case

@MonstoBusta
Copy link
Author

MonstoBusta commented Sep 26, 2024

5 to 10 apps (that are unique (demo & game itself count as 1), with 10 being preferable to not have too many edge case

So I presume that Chicken Fall Prologue is being counted as a separate game here rather than a demo (with Chicken Fall and Chicken Fall Prologue both having demos). Fine, I'll hope that more Godot 4 games use Wwise in the future

MonstoBusta and others added 3 commits September 26, 2024 17:19
Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
…r some reason

Co-authored-by: Antoine Rybacki <15911822+Lifeismana@users.noreply.github.com>
Copy link
Author

@MonstoBusta MonstoBusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't appreciate you removing Linux suport, but whatever

AkSoundEngine.dll is now called AkUnitySoundEngine.dll in newer versions of the wwise integration
It is now called AkUnitySoundEngine.dll
@Lifeismana
Copy link
Collaborator

There's no use in keeping the linux version when it doesn't help to detect more games

@MonstoBusta MonstoBusta reopened this Sep 30, 2024
@MonstoBusta
Copy link
Author

MonstoBusta commented Sep 30, 2024

apologies, I closed the pull request hoping that it wouldn't put my Unity commits into here. I cannot review without approving the changes btw

@MonstoBusta MonstoBusta changed the title Updated Wwise detection to account for Godot plugin libraries Updated Wwise detection to account for Godot plugin libraries and new Unity library Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

3 participants