From 485ade37f11fd8a361f0e47df4c78f7bffdecc90 Mon Sep 17 00:00:00 2001 From: Alexander Karpov Date: Fri, 26 Oct 2018 22:42:53 +0300 Subject: [PATCH 1/3] Changed story button pressed event name --- Stepic/AmplitudeAnalyticsEvents.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Stepic/AmplitudeAnalyticsEvents.swift b/Stepic/AmplitudeAnalyticsEvents.swift index 2c2d901d68..79fe0e9cdb 100644 --- a/Stepic/AmplitudeAnalyticsEvents.swift +++ b/Stepic/AmplitudeAnalyticsEvents.swift @@ -302,7 +302,7 @@ struct AmplitudeAnalyticsEvents { static func buttonPressed(id: Int, position: Int) -> AnalyticsEvent { return AnalyticsEvent( - name: "Button pressed", + name: "Story button pressed", parameters: [ "id": id, "position": position From 5716197b020db572fb1f348fd43dfc6b655bfdcb Mon Sep 17 00:00:00 2001 From: Alexander Karpov Date: Sat, 27 Oct 2018 11:20:50 +0300 Subject: [PATCH 2/3] fix continue course tooltip --- Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift b/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift index 5b597eec9b..fb5a123377 100644 --- a/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift +++ b/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift @@ -78,5 +78,7 @@ extension ContinueCourseView: ProgrammaticallyInitializableViewProtocol { self.lastStepView.snp.makeConstraints { make in make.edges.equalToSuperview() } + self.setNeedsLayout() + self.layoutIfNeeded() } } From a8dac2fba5754070fa51d898806c24b18909ee2c Mon Sep 17 00:00:00 2001 From: Alexander Karpov Date: Mon, 29 Oct 2018 23:07:10 +0300 Subject: [PATCH 3/3] fix --- .../Modules/ContinueCourse/ContinueCourseViewController.swift | 2 ++ Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Stepic/Modules/ContinueCourse/ContinueCourseViewController.swift b/Stepic/Modules/ContinueCourse/ContinueCourseViewController.swift index 08e25f106f..81896f0536 100644 --- a/Stepic/Modules/ContinueCourse/ContinueCourseViewController.swift +++ b/Stepic/Modules/ContinueCourse/ContinueCourseViewController.swift @@ -82,6 +82,8 @@ extension ContinueCourseViewController: ContinueCourseViewControllerProtocol { if viewModel.shouldShowTooltip { // Cause anchor should be in true position DispatchQueue.main.async { [weak self] in + self?.continueCourseView?.setNeedsLayout() + self?.continueCourseView?.layoutIfNeeded() self?.continueLearningTooltip.show( direction: .up, in: continueCourseView, diff --git a/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift b/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift index fb5a123377..5b597eec9b 100644 --- a/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift +++ b/Stepic/Modules/ContinueCourse/View/ContinueCourseView.swift @@ -78,7 +78,5 @@ extension ContinueCourseView: ProgrammaticallyInitializableViewProtocol { self.lastStepView.snp.makeConstraints { make in make.edges.equalToSuperview() } - self.setNeedsLayout() - self.layoutIfNeeded() } }