Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax test tab dialog appearing on navigating test files using Goto Anything. #351

Conversation

UltraInstinct05
Copy link
Contributor

@UltraInstinct05 UltraInstinct05 commented Sep 17, 2021

This PR fixes a situation where navigating syntax test files using Goto Anything can be disruptive. Since the view is loaded and PD throws the dialog for those files that use tabs in test files, this results in a bad UX.

To prevent this, we simply skip files that are transiently loaded when navigating Goto Anything.

Fixes #350, fixes #177

…Goto Anything`.

This commit fixes a situation where navigating syntax test files using
`Goto Anything` can be disruptive. Since the view is loaded and PD throws
the dialog for those files that use tabs in test files, this results in
a bad UX.

To prevent this, we simply skip files that are transiently loaded when
navigating `Goto Anything`.
@FichteFoll
Copy link
Member

I have two issues with this:

  1. With where you inserted the check, automatic syntax assignment is skipped. I want to keep that.
  2. We need a way to detect when the view has been properly opened and then run the check. I know it's annoying in general, but as I stated in You MUST use spaces! error: Syntax tests do not work properly with tabs as indentation. #177 I want it to be annoying - just not while using Goto Anything and for transient views. As a general idea, I think we can start a set_timeout loop that checks whether a view id is still valid and if yes, whether the respective sheet isn't transient anymore.

@FichteFoll FichteFoll added this to the 3.3.2 milestone Oct 7, 2021
@UltraInstinct05
Copy link
Contributor Author

UltraInstinct05 commented Oct 11, 2021

With where you inserted the check, automatic syntax assignment is skipped. I want to keep that.

Shouldn't be an issue. All I need to do is move the check down.

We need a way to detect when the view has been properly opened and then run the check. I know it's annoying in general, but as I stated in You MUST use spaces! error: Syntax tests do not work properly with tabs as indentation. #177 I want it to be annoying - just not while using Goto Anything and for transient views. As a general idea, I think we can start a set_timeout loop that checks whether a view id is still valid and if yes, whether the respective sheet isn't transient anymore.

Meaning, when a user promotes the transient view (of the Goto Anything) to a regular view, you want the indentation check to take place ?

@UltraInstinct05 UltraInstinct05 deleted the fix_use_tabs_as_indentation branch February 27, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants