Add support for syntax-based folding #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regions, comment blocks, and heredocs can now be folded. Additionally, region names are now searchable using ctrl-r.
deathaxe
reviewed
Jan 12, 2025
There was a problem hiding this comment.
Syntax based folding is one of the possibly more tricky ones, which may easily cause trouble if syntax is not accurate.
I've added some notes about known limitations.
Maybe we can considder adding punctuation.section.group and punctuation.section.braces as well, if they are scoped well enough (pairs can be found).
|
@deathaxe Thank you for your help. I've incorporated your suggestions into the latest commit. Groups and braces are folded correctly from what I've seen. |
matteocoder
force-pushed
the
region-fold
branch
from
0c2ed8f to
9ecdc80
Compare
This prevents strings that are not heredocs from being foldable.
deathaxe
reviewed
Jan 12, 2025
Co-authored-by: deathaxe <deathaxe82@googlemail.com>
deathaxe
approved these changes
Jan 12, 2025
|
Thank you, both! |
|
Thank you @michaelblyons and @deathaxe for helping me with these contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regions, comment blocks, and heredocs can now be folded. Additionally, region names are now searchable using ctrl-r.