fix: remove init migrate #1009
fix: remove init migrate #1009
Conversation
|
/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend --refs substra-backend=feat/align-task-profiling-function-profiling,substra-frontend=feat/align-task-profiling-function-profiling |
guilhem-barthes
force-pushed
the
fix/remove-init-migrate
branch
from
21ffe95
to
2f0ac3c
Compare
|
/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend --refs substra-backend=feat/align-task-profiling-function-profiling,substra-frontend=feat/align-task-profiling-function-profiling |
|
End to end tests: ❌ FAILURE “You shall not pass!” ― Gandalf, The Lord of the Rings, The Fellowship of the Ring |
|
/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend |
|
/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend |
|
End to end tests: ❌ FAILURE That's a shame. |
|
/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend |
|
/e2e --tests sdk,substrafl,doc,mnist,camelyon,frontend |
|
End to end tests: ✔️ SUCCESS “To infinity and beyond!” ― Buzz Lightyear, Toy Story |
| @@ -6,7 +6,6 @@ metadata: | |||
| {{ include "substra.labels" . | nindent 4 }} | |||
| app.kubernetes.io/name: {{ template "substra.fullname" . }}-migrations | |||
| annotations: | |||
| "helm.sh/hook": post-install,post-upgrade | |||
There was a problem hiding this comment.
I'm not very familiar with helm hook, but are we changing the triggers for the migration job?
There was a problem hiding this comment.
Before, we had this job (which did migrations) +this job applied after the deployment stabilised which did migration + user/organization management. This PR remove the init container doing migration in the server, and trigger the job when the deployment is started
There was a problem hiding this comment.
Sorry I'm not sure I follow which jobs are which when you say "this job" and "this job". Afaik the migration job is the only one job we have.
|
/e2e |
1 similar comment
|
/e2e |
|
End to end tests: ✔️ SUCCESS Awesome! 🎉 |
…InitContainer` Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
…of `init-migrate` Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
fix/remove-init-migrate
branch
from
c251c41
to
ce98eab
Compare
Signed-off-by: Guilhem Barthés <guilhem.barthes@owkin.com>
Description
How has this been tested?
Checklist