Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove axios full error log for setup (e.g. when Project is deleted or created), like with a 504 #605

Closed
plocket opened this issue Sep 2, 2022 · 0 comments · Fixed by #632 or #662
Closed

Remove axios full error log for setup (e.g. when Project is deleted or created), like with a 504 #605

plocket opened this issue Sep 2, 2022 · 0 comments · Fixed by #632 or #662

Comments

@plocket
Copy link
Collaborator

plocket commented Sep 2, 2022 •
edited
Loading

Do print the error message/status, though.

[Maybe duplicate of or addition to #550.]
@plocket plocket changed the title Remove log when project is deleted Remove log when project is deleted or created, like with a 504 Sep 2, 2022
@plocket plocket changed the title Remove log when project is deleted or created, like with a 504 Remove axios error log when project is deleted or created, like with a 504 Sep 2, 2022
@plocket plocket changed the title Remove axios error log when project is deleted or created, like with a 504 Remove axios error log for setup (e.g. when Project is deleted or created), like with a 504 Sep 2, 2022
@plocket plocket changed the title Remove axios error log for setup (e.g. when Project is deleted or created), like with a 504 Remove axios full error log for setup (e.g. when Project is deleted or created), like with a 504 Sep 2, 2022
BryceStevenWilley added a commit that referenced this issue Dec 12, 2022
@BryceStevenWilley
Use Axios's toJSON method to make shorter errors
21b02de 
On an example erroring docassemble server (for example, this server returning
a [502 to a delete project](https://github.com/SuffolkLITLab/docassemble-EFSPIntegration/actions/runs/3641406524/jobs/6147303425)),
the entire axios error will print, which is that case in 1.8k lines, most of it
being garbage.

Axios has a `toJSON()` method on errors that should reduce length of the errors
being shown, as it will not print the most annoying parts of the long errors,
like the internal Axios socket objects

Still need to test, as it's difficult to get a server to 502 on
demand.

Fix #605.
@BryceStevenWilley BryceStevenWilley mentioned this issue Dec 12, 2022
Merged
BryceStevenWilley added a commit that referenced this issue Dec 13, 2022
@BryceStevenWilley
Use Axios's toJSON method to make shorter errors
1c24eb4 
On an example erroring docassemble server (for example, this server returning
a [502 to a delete project](https://github.com/SuffolkLITLab/docassemble-EFSPIntegration/actions/runs/3641406524/jobs/6147303425)),
the entire axios error will print, which is that case in 1.8k lines, most of it
being garbage.

Axios has a `toJSON()` method on errors that should reduce length of the errors
being shown, as it will not print the most annoying parts of the long errors,
like the internal Axios socket objects

Still need to test, as it's difficult to get a server to 502 on
demand.

Fix #605.
BryceStevenWilley added a commit that referenced this issue Mar 2, 2023
@BryceStevenWilley
Use Axios's toJSON method to make shorter errors
eacfa9f 
On an example erroring docassemble server (for example, this server returning
a [502 to a delete project](https://github.com/SuffolkLITLab/docassemble-EFSPIntegration/actions/runs/3641406524/jobs/6147303425)),
the entire axios error will print, which is that case in 1.8k lines, most of it
being garbage.

Axios has a `toJSON()` method on errors that should reduce length of the errors
being shown, as it will not print the most annoying parts of the long errors,
like the internal Axios socket objects

Still need to test, as it's difficult to get a server to 502 on
demand.

Fix #605.
BryceStevenWilley added a commit that referenced this issue Mar 10, 2023
@BryceStevenWilley @plocket
Use Axios's toJSON method to make shorter errors (#632)
bdbe48b 
* Use Axios's `toJSON` method to make shorter errors

On an example erroring docassemble server (for example, this server returning
a [502 to a delete project](https://github.com/SuffolkLITLab/docassemble-EFSPIntegration/actions/runs/3641406524/jobs/6147303425)),
the entire axios error will print, which is that case in 1.8k lines, most of it
being garbage.

Axios has a `toJSON()` method on errors that should reduce length of the errors
being shown, as it will not print the most annoying parts of the long errors,
like the internal Axios socket objects

Still need to test, as it's difficult to get a server to 502 on
demand.

Fix #605.

* Actually fail when we log the errors
* Move `toJSON()` calls to docassemble_api_REST
* Add better comment to `process.exitCode`

Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>
BryceStevenWilley added a commit that referenced this issue Mar 10, 2023
@BryceStevenWilley @plocket
Use Axios's toJSON method to make shorter errors (#632)
5f57588 
* Use Axios's `toJSON` method to make shorter errors

On an example erroring docassemble server (for example, this server returning
a [502 to a delete project](https://github.com/SuffolkLITLab/docassemble-EFSPIntegration/actions/runs/3641406524/jobs/6147303425)),
the entire axios error will print, which is that case in 1.8k lines, most of it
being garbage.

Axios has a `toJSON()` method on errors that should reduce length of the errors
being shown, as it will not print the most annoying parts of the long errors,
like the internal Axios socket objects

Still need to test, as it's difficult to get a server to 502 on
demand.

Fix #605.

* Actually fail when we log the errors
* Move `toJSON()` calls to docassemble_api_REST
* Add better comment to `process.exitCode`

Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>
@BryceStevenWilley BryceStevenWilley mentioned this issue Mar 10, 2023
Merged
BryceStevenWilley added a commit that referenced this issue Mar 13, 2023
@BryceStevenWilley @plocket
Use Axios's toJSON method to make shorter errors (#632)
9c0f2a0 
* Use Axios's `toJSON` method to make shorter errors

On an example erroring docassemble server (for example, this server returning
a [502 to a delete project](https://github.com/SuffolkLITLab/docassemble-EFSPIntegration/actions/runs/3641406524/jobs/6147303425)),
the entire axios error will print, which is that case in 1.8k lines, most of it
being garbage.

Axios has a `toJSON()` method on errors that should reduce length of the errors
being shown, as it will not print the most annoying parts of the long errors,
like the internal Axios socket objects

Still need to test, as it's difficult to get a server to 502 on
demand.

Fix #605.

* Actually fail when we log the errors
* Move `toJSON()` calls to docassemble_api_REST
* Add better comment to `process.exitCode`

Co-authored-by: plocket <52798256+plocket@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@plocket