Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring emails #136

Merged
merged 7 commits into from
Jun 6, 2023
Merged

Monitoring emails #136

merged 7 commits into from
Jun 6, 2023

Conversation

BryceStevenWilley
Copy link
Collaborator

@BryceStevenWilley BryceStevenWilley commented Jun 5, 2023

Let's us send notifications to an email whenever there's an error log, similar to docassemble's error notification email. Should help uptime, and makes me a lot less nervous about deploying new versions of the server (something I'm going to have do a lot more in the next few months).

Contains a few other refactors as well:

  • moves GetEnv to the StdLib class, and consolidates usage (was originally on a EFM module specific class, and copied in a few different places)
  • changes some log.errors to log.warns, since they wouldn't really be errors, or something I'd want to be informed of.
  • a bug fix to make the /user/ API more intuitive; will now let non-firm users call GET /user/{my-user-id}, instead of only being able to call GET /user/ (the latter usually needs firm access for arbitrary users, but we can tell when the requesting user is the same as the requested user).

Already tested locally. Going to sleep on it, review myself, then merge. Hard to write unit tests (or integration tests) for something like this.

@BryceStevenWilley BryceStevenWilley merged commit a75e9d1 into main Jun 6, 2023
@BryceStevenWilley BryceStevenWilley deleted the monitoring branch June 6, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant