Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. session list cleanups #593

Merged
merged 6 commits into from
Oct 4, 2022
Merged

Misc. session list cleanups #593

merged 6 commits into from
Oct 4, 2022

Conversation

nonprofittechy
Copy link
Member

This has some small cleanups to the session list page.

  • Redirect to sign-in page if user is logged out
  • Default to not showing interviews that are on page 1
  • Allow author to specify a list of filenames that won't appear on the session list page (and a new global config option)
  • Reset to page 1 if a session is renamed
  • Show the display title (including auto_title) as a placeholder when someone clicks to rename a session

Fix #578 Fix #571 Fix #573 Fix #572 #592

@mnewsted
Copy link

mnewsted commented Oct 4, 2022

I like these changes @nonprofittechy . Thanks! I'm a little confused by this one:

  • Show the display title (including auto_title) as a placeholder when someone clicks to rename a session

Which is display title? Is auto_title the default plaintiffs v. defendants if it's a court case?

@nonprofittechy
Copy link
Member Author

Right, it's whatever is in ordinary weight on the session list (not the bold clickable title)

And yes, the default is users v. other_party

Copy link
Contributor

@BryceStevenWilley BryceStevenWilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't do a UI review, but Matt and you will have better thoughts there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment