-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rx antenna pattern #432
Rx antenna pattern #432
Conversation
See experiment pull request: SuperDARNCanada/borealis_experiments#10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, there are a few more things that should be done though:
- Update the docs
- Create some failing tests of bad
rx_antenna_phases
that failexperiment_unittests.py
to ensure that the validator is well-behaved
Updated the docs where I could determine that rx_antenna_pattern should be talked about. Also added 5 new tests to fail the unit test when testing rx_antenna_pattern:
all five tests were run on sdc-lab and they failed with the expected returns. The new full_fov.py experiment (using the rx_antenna_pattern option) also passes the unit test still. |
Co-authored-by: Remington Rohel <77300402+RemingtonRohel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typos in the docs, but otherwise looks good!
Phased rx take 2 implementation of rx antenna pattern into unit tests and full fov experiment. Related to PR from SuperDARNCanada/borealis#432
Added functionality to borealis to accept a function defined in the experiment that will return specific phases for the rx antennas when processing data to rawacf.