Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rx antenna pattern #432

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Rx antenna pattern #432

merged 5 commits into from
Jan 31, 2024

Conversation

Doreban
Copy link
Contributor

@Doreban Doreban commented Jan 30, 2024

Added functionality to borealis to accept a function defined in the experiment that will return specific phases for the rx antennas when processing data to rawacf.

@Doreban
Copy link
Contributor Author

Doreban commented Jan 30, 2024

See experiment pull request: SuperDARNCanada/borealis_experiments#10

Copy link
Contributor

@RemingtonRohel RemingtonRohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, there are a few more things that should be done though:

  • Update the docs
  • Create some failing tests of bad rx_antenna_phases that fail experiment_unittests.py to ensure that the validator is well-behaved

@Doreban
Copy link
Contributor Author

Doreban commented Jan 31, 2024

Updated the docs where I could determine that rx_antenna_pattern should be talked about.

Also added 5 new tests to fail the unit test when testing rx_antenna_pattern:

  • not callable -> fails if the passed parameter is not a function
  • magnitude -> fails if any element of the result is greater than 1
  • wrong shape -> fails if the dimensions of the output array are not [beam_pattern, num_antennas]
  • not ndarray -> fails if the return value is not an ndarray
  • bad intr return -> fails due to improper shape of return. The rx_antenna_pattern returns a correct result for the main array, but an incorrect shape when run for the interference array (assumed an offset parameter of -100 and type float)

all five tests were run on sdc-lab and they failed with the expected returns.

The new full_fov.py experiment (using the rx_antenna_pattern option) also passes the unit test still.

Co-authored-by: Remington Rohel <77300402+RemingtonRohel@users.noreply.github.com>
Copy link
Contributor

@RemingtonRohel RemingtonRohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typos in the docs, but otherwise looks good!

@Doreban Doreban merged commit b5cdf67 into develop Jan 31, 2024
@Doreban Doreban deleted the rx_antenna_pattern branch January 31, 2024 21:56
Doreban added a commit to SuperDARNCanada/borealis_experiments that referenced this pull request Jan 31, 2024
Phased rx take 2 implementation of rx antenna pattern into unit tests and full fov experiment. Related to PR from SuperDARNCanada/borealis#432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants