From c82c720a030e2e3cb180f04a89ca6b4c0b2b6535 Mon Sep 17 00:00:00 2001 From: David Jennes Date: Wed, 16 Aug 2017 23:25:11 +0200 Subject: [PATCH] execute xcode lint step using bundler --- CHANGELOG.md | 4 +++- StencilSwiftKit.xcodeproj/project.pbxproj | 16 ++++++++++++++-- .../xcshareddata/xcschemes/Tests.xcscheme | 4 +++- 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49fbb1d4..4e97d07a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,9 @@ _None_ ### Internal Changes -_None_ +* Ensure `swiftlint` is run using `bundler`. + [David Jennes](https://github.com/djbe) + [#59](https://github.com/SwiftGen/StencilSwiftKit/pull/59) ## 2.0.1 diff --git a/StencilSwiftKit.xcodeproj/project.pbxproj b/StencilSwiftKit.xcodeproj/project.pbxproj index ffc1db14..f26bb208 100644 --- a/StencilSwiftKit.xcodeproj/project.pbxproj +++ b/StencilSwiftKit.xcodeproj/project.pbxproj @@ -192,7 +192,7 @@ isa = PBXProject; attributes = { LastSwiftUpdateCheck = 0800; - LastUpgradeCheck = 0800; + LastUpgradeCheck = 0900; ORGANIZATIONNAME = AliSoftware; TargetAttributes = { 09A87B4F1BCCA2C600D9B9F5 = { @@ -260,7 +260,7 @@ ); runOnlyForDeploymentPostprocessing = 0; shellPath = /bin/sh; - shellScript = "if [[ ! $CI ]]; then\n rake lint:code\n rake lint:tests\nfi"; + shellScript = "if [[ ! $CI ]]; then\n [[ -r ~/.profile ]] && source ~/.profile\n if [[ `which bundler` ]]; then\n bundle exec rake lint:tests\n bundle exec rake lint:output\n else\n echo \"warning: bundler not found, can't lint code. Please install bundler then run bundle install.\"\n fi\nfi"; }; DE127EA8748200EF28090721 /* [CP] Embed Pods Frameworks */ = { isa = PBXShellScriptBuildPhase; @@ -331,14 +331,20 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; CLANG_WARN_SUSPICIOUS_MOVE = YES; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; @@ -377,14 +383,20 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; CLANG_WARN_SUSPICIOUS_MOVE = YES; CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; diff --git a/StencilSwiftKit.xcodeproj/xcshareddata/xcschemes/Tests.xcscheme b/StencilSwiftKit.xcodeproj/xcshareddata/xcschemes/Tests.xcscheme index 16b1beda..87a793d1 100644 --- a/StencilSwiftKit.xcodeproj/xcshareddata/xcschemes/Tests.xcscheme +++ b/StencilSwiftKit.xcodeproj/xcshareddata/xcschemes/Tests.xcscheme @@ -1,6 +1,6 @@