Refactor stencil swift extensions registration for easier use with an existing Extension.
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
approved these changes
Jan 27, 2017
There was a problem hiding this comment.
Looks ok to me
Can't merge myself though, as I'll probably need a rebase not that the CHANGELOG has other entries by recently merged PR… and I'm in the train with poor connection and fear I'll loose it in the middle of the rebase+merge process 😉
I'll let you rebase + merge
|
will do |
… existing `Extension`.
djbe
force-pushed
the
feature/refactor-extension-creation
branch
from
f51f441 to
77f033e
Compare
|
Do note that I can't merge, only you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.