Fix Xcode 10b / Swift 4.2 compiler issue (type-checker timeout) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
force-pushed
the
feature/fix-92
branch
from
c51d04b to
22217fc
Compare
AliSoftware
force-pushed
the
feature/fix-92
branch
from
22217fc to
0be9654
Compare
djbe
reviewed
Jul 21, 2018
There was a problem hiding this comment.
I get that this is an issue now, but we have to keep in mind that this is for a bug in an unreleased Swift version.
Should we actually merge this, or just keep the branch while the issue exists? Or monitor this for every Xcode release until the issue is fixed, and rollback the changes?
|
I'd say the change doesn't harm much (more verbose sure but ¯\_(ツ)_/¯ ) so why not |
|
Works for me. We can check later and remove the hints, although I'd keep the typealias, that's nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #92 by adding hints to help the type-checker and avoid a timeout during compilation.