Rename default templates to swift2
#47
Conversation
djbe
force-pushed
the
feature/breaking/default-to-swift2
branch
3 times, most recently
from
aa1708a to
3c734b5
Compare
|
That's quite a lot of files to review 🙄 |
|
As long as the templates look ok, everything should be fine. The tests ensure that 😄 |
|
I should maybe add a flag to control the allValues generation, in case people don't want it. |
djbe
force-pushed
the
feature/breaking/default-to-swift2
branch
from
e1c8593 to
1e8c057
Compare
| @@ -15,11 +15,12 @@ It also takes into account any namespacing folder in your Assets Catalogs (i.e. | |||
|
|
|||
| ## Customization | |||
|
|
|||
| You can customize some elements of this template by overriding the following parameters when invoking `swiftgen` in the command line, using `--param <paramName> <newValue>` | |||
| You can customize some elements of this template by overriding the following parameters when invoking `swiftgen` in the command line, using `--param <paramName>=<newValue>` | |||
There was a problem hiding this comment.
Should we repeat there that people can also just use --param <paramName> for boolean parameters, especially since this template use one (noAllValues)?
There was a problem hiding this comment.
Nah, I'd make a separate PR changing those lines to point to the StencilSwiftKit docs (or new SwiftGen docs) explaining how to customise templates.
| @@ -2,8 +2,8 @@ | |||
|
|
|||
| | Name | Description | | |||
| | --------- | ----------------- | | |||
| | File name | storyboards-osx-default.stencil | | |||
| | Invocation example | `swiftgen storyboards -t osx-default …` | | |||
| | File name | storyboards/macOS-swift2.stencil | | |||
There was a problem hiding this comment.
Those documentation files themselves should be renamed macOS-swift2.md, etc. right?
| enum This { | ||
|
|
||
| enum Is { | ||
| static let Deep = L10n.tr("settings.navigation-bar.title.deeper.than.we.can.handle.no.really.this.is.deep") |
There was a problem hiding this comment.
That key name always makes me laugh, like… this is psychologically deep 😆
| @@ -14,11 +14,12 @@ | |||
|
|
|||
| ## Customization | |||
|
|
|||
| You can customize some elements of this template by overriding the following parameters when invoking `swiftgen` in the command line, using `--param <paramName> <newValue>` | |||
| You can customize some elements of this template by overriding the following parameters when invoking `swiftgen` in the command line, using `--param <paramName>=<newValue>` | |||
There was a problem hiding this comment.
Same q about --param <paramName> for boolean flags like noComments
|
This feels sooooo good: |
|
Man, did you see the remove deprecated variables PR? #45 |
Fixes #11
noCommentsas parameter to strings template