Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review, fix, merge dependents for phpstan #8

Closed
8 tasks done
jrushlow opened this issue Jun 11, 2024 · 0 comments
Closed
8 tasks done

Review, fix, merge dependents for phpstan #8

jrushlow opened this issue Jun 11, 2024 · 0 comments
Assignees

Comments

@jrushlow
Copy link
Contributor

jrushlow commented Jun 11, 2024

From PR #7 :

Implementing tools/phpstan in say reset-password-bundle, so we can remove the dependency requirement in the project's composer.json (require-dev), causes the test suite to blow up. our global phpstan CI run looks for vendor/bin/phpstan. This changes it to tools/phpstan/vendor/bin/phpstan .


Review / update these repos if they're using phpstan as a project dependency (implement tools/* & composer scripts)

@jrushlow jrushlow self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant