Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GadgetronImageData from SIRFImageData #537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Feb 4, 2020

I've created an ISMRMRD::ImageHeader from the VoxelisedGeometricalInfo3D, and filled in as many fields as possible (but not yet debugged).

@evgueni-ovtchinnikov I'm not sure how to convert the ISMRMRD::ImageHeader to an ImageWrap, could you advise?

My two current ideas are to do:

  1. ISMRMRD::ImageHeader->ISMRMRD::Image<float>->ImageWrap
  2. ISMRMRD::ImageHeader-> directly to ImageWrap.

Any ideas? You can see the progress I've already made in the PR.

@ckolbPTB tagging you so that you don't waste any time starting from scratch.

@evgueni-ovtchinnikov
Copy link
Contributor

evgueni-ovtchinnikov commented Feb 4, 2020

ImageWrap is constructed from image type (stored in ISMRMRD::ImageHeader property data_type) and void pointer to ISMRMRD::Image, so go the first route.

@evgueni-ovtchinnikov
Copy link
Contributor

Forgot to add: ImageWrap takes the ownership of the image whose pointer it receives, so it must be image just created by new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants