sickchill: initial version v2020.11.24-1

[Nyaran]

Motivation: Add the package SickChill. The latest version of SickChill is running with Python3 and also change the startup file, so the package "SickBeard Custom" is not valid to install SickChill

Build: sickchill_noarch-all_20210313-1.spk (Don't browse the package, use the download option on top-bar)

Checklist

• Build rule all-supported completed successfully
• Package upgrade completed successfully
• New installation of package completed successfully

[miigotu]

Should probably remove the fork selection UI, no need for it in this

Possibly could replace it with username/password selection for the sickchill GUI.

[Nyaran]

You are right, I'm going to work on it

[miigotu]

@ymartin59 @th0ma7 Can one of you take a look at this, please? SickChill is python3.6+ only now and users currently have no way to run SC.

[BKSteve]

@Nyaran thanks for this, looking forward to SynoCommunity publishing the SickChill package.

[goldo82]

Hi guys, thanks for this great work !!!

My 2 cents feedback.

I have installed this spk (python 3 was already installed on my system) and imported by backup. It worked like a charm !
Now I can get rid of the sickbeard_custom package ;)

All the best,
Cyp

[Nyaran]

sickchill_noarch-all_20200911-0.zip

I built this with a minimal change so our users can test it:

diff --git a/spk/sickchill/src/service-setup.sh b/spk/sickchill/src/service-setup.sh
index 09c80292..ec57fce4 100644
--- a/spk/sickchill/src/service-setup.sh
+++ b/spk/sickchill/src/service-setup.sh
@@ -23,7 +23,7 @@ service_postinst ()
         # Clone the repository
         ${GIT} clone --depth 10 --recursive -q -b master git://github.com/SickChill/SickChill.git ${SYNOPKG_PKGDEST}/var/SickChill > /dev/null 2>&1
 
-      if [ -n "${wizard_username}" ] && [ -n "${wizard_password}" ]; then
+      if [ -n "${wizard_username}" ] && [ -n "${wizard_password}" ] && [ ! -f "${SC_CFG_FILE}" ]; then
         mkdir -p ${SC_DATA_DIR}
         cat << EOF > ${SC_CFG_FILE}
 [General]

I'm not sure if that condition can happen, because, on install process, the sickchill/data folder doesn't exist and on upgrade process, the previous if avoid entering there. Anyway I think is a good addition

[Nyaran]

Latest build added to first message

[miigotu]

@Nyaran you might have missed my PR to your branch =P

[miigotu]

Nyaran#1

[Nyaran]

@Nyaran you might have missed my PR to your branch =P

OMG! Sorry, I didn't noticed

[miigotu]

Lol it's ok, but I fixed an issue with haproxy for sickbeard-custom and an error in sadnzbd installer too, as well as editing the config.ini if it exists (idk if the config/db is deleted when uninstalling?)

If this gets merged we can think about adding prerm, pre_upgrade, post_upgrade to back up and restore db/config for data stability

[Nyaran]

All data is deleted after uninstall (I do it a lot of times while validating the package installer), I can accept you PR, but maybe the fix on sadnzbd should be done in separate PR

[miigotu]

Might want to steal this bit too: miigotu@7a204e5

[miigotu]

I think that removing the space so that var is actually set in the sabnzbd plugin is so minor that it should be ok here.

[publicarray]

Hi Thanks for your contribution.

I don't usually review PR's but I thought I give it a shot.
My main concern here is that this downloads the SickChill git repository on master, meaning that the build is nondeterministic. I recommend downloading a release or checkout a tag. (just had a look at the sickrage package, it also downloads from git...) What is the policy here @hgy59 @ymartin59?

[miigotu]

@publicarray This operates the same as all forks of sickbeard in syno. sickbeard-custom, sickrage, etc
If I need to make a new branch I can, but it is better that it uses master. Master never gets PR's merged directly, everything is merged into the develop branch and only released to master as releases or hotfixes.

SickChill also has a built in updater, which is why we still use git in jails and other packages rather than a pip install so that the app can update itself

[publicarray]

@miigotu thanks for explaining, no problem, than that is fine by me.

Just aside, I don't like using other packages too much as a guide because we have older packages and sometimes it makes sense to reassess things.

[miigotu]

I agree. We used the sickbeard-custom package before because of the fork selection wizard, but it won't work anymore with our code because we are so far diverged. We are hoping to flesh this package out even further with pre_upgrade, pre_remove, post_upgrade, etc and give the plugin a more complete and fool proof install than ever before on Synology, but we need the base package to even start working on it more.

[miigotu]

Side note, we have been providing a syno package for SickChill for quite a long time outside of spksrc, as has benjv. We don't like having just an spk posted where we don't know for sure what was changed in it, so we would like to have it here for security and history if nothing else. Installing via package manager is much safer than installing some spk from a random link on the net.

[publicarray]

Just installed SickChill, Works extremely well, just some small cosmetic changes

[miigotu]

@publicarray thanks for merging.

As previously discussed we currently can't install using the wheel, because I haven't written the updater for that yet.

I'm not 100% sure, but I think the cross-cc is for the c extensions that are compiled when you pip install the dependencies and a manylinux wheel is not available. (Lxml, sqlalchemy, greenleaf)

We can set the update checker higher, right here in the package.

[marfapeco]

Hello to all,
I start by saying that I am a complete novice. Sickchill won't start after updating it from Synology packaging update. I have done the following:

1.- I uninstalled it and reinstalled it from Synology. Result: it started. Then I restored a backup. Result: now it does not load.
2.- I uninstalled it again, downloaded the pack that is in the first post above. I installed it and, perfect, it started. I restored a backup again. Result: again (although the app runs) it doesn't load as before.

What can I do to fix the problem?

Thanks for your help,

[zyrill]

@marfapeco Don't use the backup, as it seems to be broken or incompatible.

[marfapeco]

Thanks zyrill. I'll try to install from scratch, so. One question: do you know why Synology did not create a shorcut for Sickchill? It did it always before but know I have to open it manually.

[BKSteve]

Thanks zyrill. I'll try to install from scratch, so. One question: do you know why Synology did not create a shorcut for Sickchill? It did it always before but know I have to open it manually.

Check the port set in your SC config and app permissions in control panel for the other issue. Some old backups used different ports than 8081

[miigotu]

I will check out the source for this package a little bit later and see if I can fix a few issues with permissions and port forcing.

[miigotu]

Please use the issue tracker at https://github.com/SickChill/synology-sickchill (our org fork of spksrc, where we will PR from)

I had fixed some of these problems in my personal fork, but I was worried about making too many changes to the PR when it was so close to being accepted. A new PR will be made hopefully today.

[marfapeco]

Thanks zyrill. I'll try to install from scratch, so. One question: do you know why Synology did not create a shorcut for Sickchill? It did it always before but know I have to open it manually.

Check the port set in your SC config and app permissions in control panel for the other issue. Some old backups used different ports than 8081

Ok. It was helpfull. I could restore it. The problem was the port, I had another one. What I do not know is where I have to chang the port in SC config and how.
And about the shortcut, I have given permissionn to SC in app permissionns but I do not know how to create now the shortcut.
Thanks again zyrill.

[miigotu]

Please move this discussion to Sickchill: https://github.com/SickChill/SickChill/issues/7070 (or open a new issue there for other problems)

[marfapeco]

Please move this discussion to Sickchill: SickChill/SickChill#7070 (or open a new issue there for other problems)

Done. Sorry.

[Manfred73]

For some reason SickChill stopped working on my Synology today.
I removed the synology package and found and installed the one mentioned here: sickchill_noarch-all_20210313-1.spk
After installation it notified me there was an update, so I also installed the update.
After the updated, I restored my files from a backup.
However, when I try to access the webinterface, it says SickChill page cannot be found. In the package overview of Synology, SickChill status says it's running. There are no errors in the Sickchill.log.

*** UPDATE ***
A fresh install without restoring any files is also not working.

[miigotu]

This is not the place for issue reports, please open an issue on SickChill/synology-sickchill (our spksrc fork)

[Manfred73]

Done

[miigotu]

@publicarray I have to make changes to the other PR, I missed the change someone added that removed the git clone and now SC is updating using a tar rather than a git clean && git pull. this completely removes config .

[Manfred73]

Could it be that the incorrect update of SickChill is causing the problems I'm experiencing now?

I noticed in my backup config.ini is in /volume1/@appstore/sickchill/var but there is now a config.ini in /volume1/@appstore/sickchill/var/data.
Should files like config.ini, cache.db, sickchill.db, etc. now be moved to the data folder?

Am I right that:

• /volume1/@appstore/sickchill/var/cache should now be /volume1/@appstore/sickchill/var/data/cache
• /volume1/@appstore/sickchill/var/*db* should now be /volume1/@appstore/sickchill/var/data/*db*
• /volume1/@appstore/sickchill/var/config.ini should now be /volume1/@appstore/sickchill/var/data/config.ini

and that only the data directory needs to be backed up?

After install the /volume1/@appstore/sickchill/var/data/config.ini only contains (all my other config, including web_port, is gone):
[General]
web_username = <username>
web_password = <password>
branch = master
cur_commit_hash = 1e656000415b1e32dee9e04dabc53a3636045c02
cur_commit_branch = v2021.03.10-1

[Manfred73]

Problem with SickChill page no longer available solved. I read here that the port was changed to 8081 (used to be 8899). After updating, the new port was not working, since it was blocked by Synology Firewall.

I restored my configuration and set port in the restored config.ini to 8081 and opend it in the Firewall. Moved all files (cache, *db* and config.ini to the data folder. All seems to be working again.

[JediJah]

Hi I wasn't sure if SickChill was ready for DSM 7.0. I found out it wasn't after I updated. Guess I will wait patiently for you to get to a fix. Thanks as always for this great software.

[hgy59]

Hi I wasn't sure if SickChill was ready for DSM 7.0. I found out it wasn't after I updated.

you are right, sickchill is not updated for DSM7. I have added sickchill to the package list in #4524.
And there is PR #4538 in progress, but not ready for DSM7 too.

[miigotu]

Other PR needs updated for when I merged SickChill develop into master. We no longer will be including bundled libs, so either we need to provide wheels for dependencies or just use a pip install. (SC will be able to update itself through pip).

[hairyhippy]

I haven't upgraded to DSM 7.0 yet and probably won't until I can afford a new NAS as the current will struggle I think with DSM 7.

Since yesterday or the day before after some package updates (pretty sure one was Python), Sickchill stopped and won't restart. My back ups are old but if the only solution is to uninstall and reinstall and start from scratch then so be it unless someone else has got a better solution?

[hairyhippy]

So I uninstalled and reinstalled...
Once ran, it stated approx 800 commits behind so updated. Now the package won't run. Any suggestions?

[MichelRabozee]

Hello, please read https://github.com/SickChill/synology-sickchill/issues/3#issuecomment-883508042 and https://github.com/SickChill/SickChill/issues/7316#issuecomment-884220658, maybe that can help you.

[FaiqH]

Hello, please read SickChill#3 (comment) and SickChill/SickChill#7316 (comment), maybe that can help you.

tried both, it did not work.

[hairyhippy]

Hello, please read SickChill#3 (comment) and SickChill/SickChill#7316 (comment), maybe that can help you.

The first of these worked for me. Thank you!

[hairyhippy]

Actually, it hasn't been sorted completely. After following those instructions, it still said 22 commits behind so I updated and it launched fine. Restored back up and restarted Sickchill. Now the Web GUI won't load, says the page can't be reached...

Edit: I remembered that the backup had port 8083 as this was what was required when this package was first issued. I edited the config in /volume1/@appstore/sickchill/var/data to 8081 and all working again :-)

[stargater1]

...very disappointed. still no DSM 7 support?!?!?!?

[zyrill]

...very disappointed. still no DSM 7 support?!?!?!?

You realize how FOSS works, right? Nobody is stopping you from doing it... Or paying somebody else to do it.