-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel sources for DSM 6.2.3 #4399
Conversation
Bug was introduced with PR#4320 creating a duplicate usage of KERNEL_DIR (vs KERNELS_DIR) variable. Changed the kernel source dir to KERNEL_SOURCE_DIR in order to keep the new variable aligned with other distrib vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor improvement proposal.
@hgy59 and @ymartin59 I decided to go all-in and make all the in-dept changes to the kernel building process as there where way too much churn in the kernel Makefiles ... Testing still under going to confirm it builds successfully on all 5.x+ DSM. |
@ymartin59 and @hgy59 May I suggest we remove entirely all kernels < DSM-6.1. |
Honestly this was brutal... but it ends-up now working quite well. Now is pretty much the time to adjust variable names or any other change you see fit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job and big effort, really much more maintainable code !
@th0ma7 I am interested in building some USB modules for my model, how should I process? |
@ymartin59 I'll look into adjusting the wiki pages to reflect some of the change. Personally I'm more used to the in-tree by simply adapting the configuration to enable the needed device then building the needed pieces at the directory level or down to the driver specific level such as:
After this PR we should be in good shape to enable this functionality through a wrapper of some sort... more work in perspective. |
BTW, I guess the configuration adjustment helper used |
@ymartin59 forgot to mention, as the kernels are now built within the package directory tree (e.g. |
Motivation: Been waiting for kernel sources for months for DSM-6.2.3 in order to get functional modules to run.
Linked issues: #4144
Checklist
all-supported
completed successfullyChanges
modules_prepare
instead of building all the modules by default+
to EXTRAVERSION if kernel is > 4.x