Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: add version compare functions #4417

Merged
merged 2 commits into from
Jan 31, 2021

Conversation

publicarray
Copy link
Member

Motivation: Allows us to compare version strings in makefiles
Linked issues:
publicarray@50cf722#commitcomment-46543476
#4395 (comment)

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's exactly what I was about to suggest of adding the ge|le AND gt|lt.
Great job!

@publicarray
Copy link
Member Author

Thanks @th0ma7! It was a group effort!

@hgy59 hgy59 merged commit 8a7bb26 into SynoCommunity:master Jan 31, 2021
@publicarray publicarray deleted the version_compare branch February 1, 2021 05:36
brice-fromentin pushed a commit to brice-fromentin/spksrc-dotnet-9 that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants