Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update fish to 3.2.0 #4463

Merged
merged 2 commits into from
Mar 13, 2021
Merged

feat: update fish to 3.2.0 #4463

merged 2 commits into from
Mar 13, 2021

Conversation

etcusrvar
Copy link
Contributor

Motivation: Update fish to 3.2.0

Also, build with ncursesw instead of ncurses.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@hgy59 hgy59 merged commit 2f8caa9 into SynoCommunity:master Mar 13, 2021
@publicarray
Copy link
Member

publicarray commented Mar 13, 2021

For dsm7 and future me:
armv7/aarch64:

  -- Looking for cbreak in /github/workspace/spk/fish/work-armv7-7.0/install/var/packages/fish/target/lib/libncursesw.so
  -- Looking for cbreak in /github/workspace/spk/fish/work-armv7-7.0/install/var/packages/fish/target/lib/libncursesw.so - not found
  -- Found Curses: /github/workspace/spk/fish/work-armv7-7.0/install/var/packages/fish/target/lib/libncursesw.so  
  -- Looking for pthread.h
  -- Looking for pthread.h - not found
  CMake Error at /usr/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
    Could NOT find Threads (missing: Threads_FOUND)

x64:

  [ 20%] Building CXX object CMakeFiles/fishlib.dir/src/builtin_math.cpp.o
  In file included from /github/workspace/toolchain/syno-x64-7.0/work/x86_64-pc-linux-gnu/x86_64-pc-linux-gnu/include/c++/7.3.0/cmath:45:0,
                   from /github/workspace/spk/fish/work-x64-7.0/fish-3.2.0/src/builtin_math.cpp:8:
  /github/workspace/spk/fish/work-x64-7.0/fish-3.2.0/src/builtin_math.cpp: In function ‘int evaluate_expression(const wchar_t*, const parser_t&, io_streams_t&, const math_cmd_opts_t&, wcstring&)’:
  /github/workspace/spk/fish/work-x64-7.0/fish-3.2.0/src/builtin_math.cpp:248:18: error: ‘__builtin_isinf_sign’ is not a member of ‘std’
           if (std::isinf(v)) {
                    ^
  /github/workspace/spk/fish/work-x64-7.0/fish-3.2.0/src/builtin_math.cpp:248:18: note: suggested alternative:
  <built-in>: note:   ‘__builtin_isinf_sign’
  /github/workspace/spk/fish/work-x64-7.0/fish-3.2.0/src/builtin_math.cpp:250:25: error: ‘__builtin_isnan’ is not a member of ‘std’
           } else if (std::isnan(v)) {
                           ^
  /github/workspace/spk/fish/work-x64-7.0/fish-3.2.0/src/builtin_math.cpp:250:25: note: suggested alternative:
  <built-in>: note:   ‘__builtin_isnan’
  make[4]: *** [CMakeFiles/fishlib.dir/build.make:365: CMakeFiles/fishlib.dir/src/builtin_math.cpp.o] Error 1
  make[3]: *** [CMakeFiles/Makefile2:953: CMakeFiles/fishlib.dir/all] Error 2
  make[2]: *** [Makefile:130: all] Error 2

@etcusrvar etcusrvar deleted the fish-3.2.0 branch March 13, 2021 21:18
@publicarray publicarray mentioned this pull request Mar 14, 2021
3 tasks
brice-fromentin pushed a commit to brice-fromentin/spksrc-dotnet-9 that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants