Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix builds for DSM<7 without wizard files #4489

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Mar 11, 2021

Motivation: Build of spk packages without wizard fail for DSM < 7
Linked issues: Followup of #4395

- fix builds for DSM<7 without wizard files
@hgy59 hgy59 changed the title fix wizard folder in spksrc.spk.mk fix builds for DSM<7 without wizard files Mar 11, 2021
@hgy59 hgy59 merged commit 87776c1 into SynoCommunity:master Mar 11, 2021
@publicarray
Copy link
Member

Thanks!

@hgy59
Copy link
Contributor Author

hgy59 commented Mar 14, 2021

@publicarray unfortunately this introduced another error.
The wizard files are not packed into the spk now. The wizard files are added to the spk file if you run make two or more times.

The expression
ifneq ($(wildcard $(DSM_WIZARDS_DIR)/.*),)

evaluates to false at the first time.
I tried to get this evaluation fixed, but no success for now.
Any hint on conditionally execution of this block would be helpful.

@hgy59
Copy link
Contributor Author

hgy59 commented Mar 14, 2021

⚠️ this has broken all packages with wizards on the master.

hgy59 added a commit to hgy59/spksrc that referenced this pull request Mar 14, 2021
- fix missing wizards introduced with SynoCommunity#4489
- working solution for packages without wizards as expected by SynoCommunity#4489
@hgy59 hgy59 mentioned this pull request Mar 14, 2021
hgy59 added a commit that referenced this pull request Mar 14, 2021
- fix missing wizards introduced with #4489
- working solution for packages without wizards as expected by #4489
brice-fromentin pushed a commit to brice-fromentin/spksrc-dotnet-9 that referenced this pull request Nov 27, 2024
- fix builds for DSM<7 without wizard files
brice-fromentin pushed a commit to brice-fromentin/spksrc-dotnet-9 that referenced this pull request Nov 27, 2024
- fix missing wizards introduced with SynoCommunity#4489
- working solution for packages without wizards as expected by SynoCommunity#4489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants