-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mono 6.12 for DSM 7.0 #4669
Mono 6.12 for DSM 7.0 #4669
Conversation
You may exclude arch 88f6281 |
Is this ready to get merged to master and released? |
No it is not ready yet. @MarkCiliaVincenti can you tell us, why you would like to have Mono on DSM7? As I commented in #4524, we do not want to create Mono packages for DSM7, as all packages depending on Mono are outdated and migrated to dotnet (except AFAICR sonarr, but this will only available when migrated to dotnet). |
The issue is indeed Sonarr and it will take a long while before it is
migrated away from the old netframework.
…On Sun, 11 Jul 2021, 17:29 hgy59, ***@***.***> wrote:
Is this ready to get merged to master and released?
No it is not ready yet.
@MarkCiliaVincenti <https://github.com/MarkCiliaVincenti> can you tell
us, why you would like to have Mono on DSM7?
As I commented in #4524
<#4524>, we do not want to
create Mono packages for DSM7, as all packages depending on Mono are
outdated and migrated to dotnet (except AFAICR sonarr, but this will only
available when migrated to dotnet).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4669 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7U7YEW4IE465NSDW2HY4DTXG2E7ANCNFSM46GINXXA>
.
|
We are also still using Mono on DSM7 (not for long I hope), so we also are interested in this. |
In this repository dotnet is used as build tool for jellyfin and some *arr-packages. I have created such dotnet package (runtime and sdk) some time ago, but never pushed it to this repository. @picrap are you interested in dotnet runtime or dotnet SDK or both? |
@MarkCiliaVincenti as for current Sonarr package I think it would be enough to publish the current Mono package (5.20.1.34-17) for DSM7. |
Not sure what you mean.
…On Sun, 11 Jul 2021, 18:33 hgy59, ***@***.***> wrote:
@MarkCiliaVincenti <https://github.com/MarkCiliaVincenti> as for current
Sonarr package I think it would be enough to publish the current Mono
package (5.20.1.34-17) for DSM7.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4669 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7U7YHVZWFGV6QJLV7OT6LTXHBXLANCNFSM46GINXXA>
.
|
@hgy59 we plan to move to net5 (or later), once we have a successful build for it, but as of today we’re still using mono (that currently plan to deploy in our package if no Mono package is available for DSM7). |
The mono packages currently available on https://synocommunity.com/packages are built for DSM6 and are not compatible with DSM7 (despite you can see the package in DSM 7 package center on your diskstation, when you added synocommunity package repository). The packages for DSM7 must specify a DSM7 revision number (i.e. >= 40000) and must not require root permissions (as our DSM6 packages have by default). By building the current mono package to target DSM7 we will get DSM7 compatible packages. |
I have created mono for DSM7. You can download the packages here: https://github.com/hgy59/spksrc/releases/tag/mono-5.20.1.34-17dsm7 But non of the depenent packages is updated for DSM7 yet (jackett, lidarr, sonarr). |
Thanks for the package! Do you plan to publish it on synocommunity repo? |
Yes I will publish those, when there is no negative feedback... |
So far so good. My package runs with the provided |
@hgy59 I've recently pushed sonarr and lidarr for DSM7 (dotnet versions only). It did not require any code changes. The first start might take extra long to start since it has to run the updater. (I've tested the downgrade/upgrade path with no issues) |
DSM7 versions of Mono 5.20.1.34-17 are now published. Within the regular delay of up to 48 hours these will be visible in DSM package manager. |
@hgy59 I can confirm Sonarr works with your mono version from your fork. But when I compiled mono from master I got the following:
To fix it I needed to clean |
For publishing I always use the same dedicated clone and I always use Another point is, that native packages with equivalent cross packages must have the same version. This is obvious and must be done on package updates, and a version check could be added to the cross makefiles. |
@hgy59 Thanks, Yea I guess I was more surprised that the error is only visible at runtime. And since I've never touched mono I did not check that mono had a native component. |
Ok I have excluded the 88f6281 arch and submitted the various fixes suggested. So far so good, all builds are green : ) |
Any chance this could be shipped soon? The problems with Sonarr are creeping up again. |
@publicarray would having a newer Mono version as this PR aims to implement resolve the issues with TLS as reported in #5051 that you were attempting to fix in #5070? |
superseded by #5677 that fixes all remaining issues. |
Motivation: Update mono to 6.12 for DSM 7.0
Linked issues: #4322
Checklist
all-supported
completed successfully