Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310: Update to version 3.10.6 #5395

Merged
merged 6 commits into from
Aug 22, 2022
Merged

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Aug 19, 2022

Description

python310: Update to version 3.10.6

NOTE: numpy fails to build using setuptools >= 64.x

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

cross/python310/Makefile Outdated Show resolved Hide resolved
@hgy59
Copy link
Contributor

hgy59 commented Aug 20, 2022

@th0ma7 see comment in numpy/numpy#22135 (comment), numpy has pinned setuptools to v59.2.0 in their environment. So this is probably not a bug, but not supported by intention.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Aug 20, 2022

@th0ma7 see comment in numpy/numpy#22135 (comment), numpy has pinned setuptools to v59.2.0 in their environment. So this is probably not a bug, but not supported by intention.

Good catch. They actually mention <=64.x numpy/numpy#22135 (comment)

@th0ma7 th0ma7 requested a review from hgy59 August 21, 2022 11:50
@th0ma7 th0ma7 self-assigned this Aug 21, 2022
@th0ma7
Copy link
Contributor Author

th0ma7 commented Aug 21, 2022

This was tested and LGTM. @hgy59 seing anything missing before I merge & shoule I wait for #5399 before publishing?

@hgy59
Copy link
Contributor

hgy59 commented Aug 21, 2022

This was tested and LGTM. @hgy59 seing anything missing before I merge & shoule I wait for #5399 before publishing?

Or you could cherry pick the setuptools-rust (3262891) from it, so #5399 will not trigger the build of all python310 dependent packages.
But I am not sure, whether it is the right way to build cryptography within crossenv. Regular builds use PyO3 and I am very confused about how pip builds cryptography with setuptools-rust and what is going on under the hood... (python is still a strange ecosystem for me...).

@th0ma7
Copy link
Contributor Author

th0ma7 commented Aug 21, 2022

cherry pick the setuptools-rust

Will do.

I am very confused about how pip builds cryptography with setuptools-rust and what is going on under the hood... (python is still a strange ecosystem for me...).

indeed, it's not all that easy to follow, nor am I understanding it all...

@th0ma7 th0ma7 merged commit f80831d into SynoCommunity:master Aug 22, 2022
@th0ma7 th0ma7 deleted the py310.6 branch August 22, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants