Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version, split chains #973

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

Haoqian-Zheng
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v2-storybook ❌ Failed (Inspect) Oct 10, 2023 11:56pm

@vercel
Copy link

vercel bot commented Oct 3, 2023

@Haoqian-Zheng is attempting to deploy a commit to the Synthetixio Team on Vercel.

A member of the Team first needs to authorize it.

@@ -30,7 +30,7 @@ export const NotifiCard: React.FC<{ onClose: () => void }> = ({ onClose }) => {

const env = isMainnet ? 'Production' : 'Development';
const cardId = isMainnet
? '283fa53b4b8e4ed1a2234615bf01d240'
? ( isL2 ? '283fa53b4b8e4ed1a2234615bf01d240' : '5ece3cd3ec504576b10ab396d619dc9b')
: '8a569abd38974f76837960bd9bf36049';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about testnet? Is the address same for op goerli and eth goerli?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently yes

@0xjocke 0xjocke merged commit d855773 into Synthetixio:add-notify-copy Oct 11, 2023
5 of 11 checks passed
@noisekit
Copy link
Contributor

Need to get checks ci task green please 🙏

0xjocke added a commit that referenced this pull request Oct 24, 2023
* add Notifi

* remove discord & change cratio save button

* ui fixes

* Deps

* Dont rely on connector

* Hide notification icon when in delegate mode

* Prettier

* Lazy load notificard

* update version, split chains (#973)

* update version, split chains

* add unread counter

* fix history icon alignment (#985)

* update version, split chains

* add unread counter

* align history icons

* Update notifi.css

* update npm package

* Fix deps

* Node v16 is deprecated

* yarn pretty:fix

* Lint issues

* add discord support (#987)

* upgrade sdk (#991)

* deps

---------

Co-authored-by: Haoqian-Zheng <haoqian.zheng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants