feat(v3.6.0): tup 230 make form plugin work #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The django-forms(-maintained) plugin expects jquery with ajax features. Our CMS was using a slim build of jQuery. The size difference is 17KB, which I consider negligible.
- less changes form original - sometimes the original html was better for styling
Also, no button styling yet.
Pointer file mimics what I do for blog CSS, which is also in source.
wesleyboar
changed the title
This is before the API change, and the tag just before CMS v3.6.0.
Regarding "--from-future-core-styles": - Core-Styles with c-button is beyond v0.3.0 at which we are pinned. - I avoid past v0.3.0, cuz API changed, and I try to limit complexity.
When we want to customize e-mail, dev should learn template override. I have to balance how much I help new devs with my own productivity.
wesleyboar
commented
Jun 15, 2022
taccsite_cms/static/site_cms/css/src/_imports/components/c-button--from-future-core-styles.css
Show resolved
Hide resolved
This returns single label and checkbox pair to one line.
taoteg
approved these changes
Jun 20, 2022
taccsite_cms/static/site_cms/css/src/_imports/components/c-button--from-future-core-styles.css
Show resolved
Hide resolved
rstijerina
approved these changes
Jun 20, 2022
|
I've moved the three optional tasks that came from code review to #498. I will merge, check pre-prod, then deploy if good (there was a UI fix since H.P. tested on pre-prod):
H.P. approved design as is (private ref.). M.S. will have new design, but I can apply it before new TACC. |
|
Process I previously mentioned for deploy was edited; new step to test final UI fix on pre-prod. |
wesleyboar
added a commit
that referenced
this pull request
Jul 6, 2022
wesleyboar
added a commit
that referenced
this pull request
Jul 6, 2022
Not a straight clone of #500. I added a little CSS and a small document to avoid cloning one template. See: - default.html.md - django.cms.forms.css
wesleyboar
commented
Jul 6, 2022
wesleyboar
added a commit
that referenced
this pull request
Jul 15, 2022
* feat(tup-230): working form plugin * docs(tup-230): clarify form submission failure * feat(tup-230): use jquery version that has ajax The django-forms(-maintained) plugin expects jquery with ajax features. Our CMS was using a slim build of jQuery. The size difference is 17KB, which I consider negligible. * feat(tup-230): make spam protection available * feat(tup-230): e-mail template (when e-mail works) * docs(tup-230): tweak comment in settings * fix(tup-230): comments & semantic html in template * fix(tup-230): revert and make some html changes - less changes form original - sometimes the original html was better for styling * feat(tup-230): style form (no design review yet) Also, no button styling yet. * chore(tup-230): rename css file, add pointer file Pointer file mimics what I do for blog CSS, which is also in source. * chore(settings): tup-308, how to set captcha keys Ref: TACC/Core-Portal-Deployments@48e6e9c * noop(settings): tup-308, add new line * fix(settings): tup-308, use new form css from #500 * fix(settings): tup-308, new form templates by #500 Not a straight clone of #500. I added a little CSS and a small document to avoid cloning one template. See: - default.html.md - django.cms.forms.css * noop(settings): tup-308, form settings from #501 * fix(settings): tup-308, css changes from #501 * fix(settings): tup-308, "*" to "(required)" I use a different solution than #501. In #501, markup was changed to "(require)": https://github.com/TACC/Core-CMS/blob/5f63bdf/taccsite_cms/templates/djangocms_forms/form_template/default.html#L27 But here, I do not edit the markup, so no need to clone template: https://github.com/TACC/Core-CMS/blob/8a46a21/taccsite_cms/templates/djangocms_forms/form_template/default.html.md * fix(css): tup-308, small form style issues - bigger gap between single checkbox and input - add gap between multiple checkbox and input - align multiple checkbox and input - simpler, less specific checkbox label selector - remove undesired label margin* * This style was ineffectual—good—in 3.6, but "fixed"—bad—when ported. * fix(css): tup-308, small form style issues - limit which help text gets margin - remove ineffectual, unnecessary margin removal - bigger gap between single checkbox and input - align single checkbox and input - add gap between multiple checkbox and input - align multiple checkbox and input - remove label margin on last of multiple checkboxes/radios - simpler, less specific checkbox label selector - remove undesired label margin* * This style was ineffectual—good—in 3.6, but "fixed"—bad—when ported. * docs(styles): typo fix for KSS comment * fix(form): tup-308 only working export formats 1. Only let users export with supported formats. 2. Update form version to rev. that supports this. Source: avryhof/djangocms-forms#8 * fix(form): delete unnecessary cloned template * fix(form): tup-308, clean up templates - remove unedited cloned template - update commit in a comment * fix(form): tup-308, move form export settings * fix(form): tup-308, remove unused file I forgot to delete this file earlier. * fix(form): tup-308, remove redundant script The removal happens form a merged PR on the plugin: avryhof/djangocms-forms#12 * chore(core-styles): v0.7.0-beta * fix(taccsite_custom): get main relevant PRs merged * docs(form): no commented settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Form plugin: update, configure, style*, document.
* The styles only use inspiration from new TUP login form. Design will later give standard CMS form styles (and later CMS-specific button styles).
Related
feat(tup-230): frontera primary button styles (i.e. add color vars) Core-CMS-Resources#144feat(tup-230): frontera primary button styles (i.e. add color vars) Core-CMS-Resources#145
Changes
django-recaptchadjangocms-formswithdjangocms-forms-maintainedc-buttonfrom core-styles v0.5+c-buttonTesting
Deployed on Frontera Pre-Prod.
Tests on TUP-230 test page. (Must log in.)
Screenshots
Screenshots of Fields & Errors
Videos of Form Submission with & w/out Captcha
no.captcha.mov
with.captcha.mov
Notes
Authorized developer should add/update a Recaptcha account with domain/s and add secret key to frontera server.
Footnotes
E-mail feature is delayed until I have bandwidth to research it and configure or fix it. ↩
The success message is top center of screen white on black (a
.cms_message). These should be styled better. ↩ ↩2 ↩3There should only be options "None" and "Recaptcha", chose "Recaptcha" ↩