Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug? Extra Save State Backups being created #722

Open
ReyVGM opened this issue Mar 8, 2024 · 3 comments
Open

Bug? Extra Save State Backups being created #722

ReyVGM opened this issue Mar 8, 2024 · 3 comments

Comments

@ReyVGM
Copy link

ReyVGM commented Mar 8, 2024

Describe the bug
I have the "Backup savestates" option enabled. It works fine, but I notice it always creates TWO backups of slot 0. It even creates that extra backup if I LOAD any save state slot.

To Reproduce
Steps to reproduce the behavior:

  1. Boot any game.
  2. Load any save slot (even if it's empty)
  3. It will create a backup called "gamename.bak.fc0" (regular backups are named "gamename-bak.fc0", notice the dash there)

Expected behavior
It should not create that extra ".bak.fc0"

Screenshots
1

(please complete the following information):

  • OS and Version: Win10 Pro 64bit
  • FCEUX 2.6.6 non QT
@ReyVGM
Copy link
Author

ReyVGM commented Jun 21, 2024

Anyone?

@negativeExponent
Copy link
Contributor

appears to be intentional regardless of a state exists or not for movie purposes

in state.cpp line 1133

string GetBackupFileName()
{
	//This backup savestate is a special one specifically made whenever a loadstate occurs so that the user's place in a movie/game is never lost
	//particularly from unintentional loadstating
	string filename;
	int x;


	filename = FCEU_MakeFName(FCEUMKF_STATE,CurrentState,0);	//Generate normal savestate filename
	x = filename.find_last_of(".");		//Find last dot
	filename = filename.substr(0,x);	//Chop off file extension
	filename.append(".bak.fc0");		//add .bak


	return filename;
}

@ReyVGM
Copy link
Author

ReyVGM commented Jun 22, 2024

I see, thanks for the info. But shouldn't that only generate when you're making a movie then?

It's kind of annoying to always have that fake backup save constantly generating even if you're not messing with making movies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants