Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display table breaks when description is too big #111

Closed
XeR opened this issue Nov 29, 2021 · 2 comments
Closed

Display table breaks when description is too big #111

XeR opened this issue Nov 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@XeR
Copy link
Contributor

XeR commented Nov 29, 2021

very long description
If the description contains very long lines, then the table will become scrollable. All the important buttons are now out of the view...

We can solve this by wrapping the text, but I don't know if this is preferred since it may result in very high rows. Another way of solving this is too add some expansion button for the description, just like this example: https://quasar.dev/vue-components/table#expanding-rows
Or maybe cut the text at some point and when the user clicks it, a popup will be displayed with the full description?

Originally posted by @JJ-8 in #110 (review)

@B-i-t-K B-i-t-K added the bug Something isn't working label Nov 29, 2021
@JJ-8
Copy link
Collaborator

JJ-8 commented Dec 4, 2021

I did some testing to see if I could find a decent solution and I have now the following:

image

The buttons will wrap to always 2x2. This will prevent an ugly 1x3 layout and an unpractical 1x4 layout. Since this result in the row being a bit higher by default, you don't have the problem often that the rows are very uneven of height because of a variable description length.

Another screenshot when a task does not contain 5 paragraphs of lorem ipsum:

image

I have also converted <pre> to <div> since that was required for the word wrapping for the description (#113).

Any thoughts about this? Is this better than vertical scrolling?
I'll create a PR for this if this is a good solution for this issue (and it is accepted that <pre> becomes <div>).

JJ-8 pushed a commit to JJ-8/CTFNote that referenced this issue Dec 4, 2021
This prevents lots of vertical scrolling when there is a long description.
Related to TFNS#111
JJ-8 pushed a commit to JJ-8/CTFNote that referenced this issue Dec 4, 2021
This prevents lots of vertical scrolling when there is a long description.
Related to TFNS#111
@frereit frereit mentioned this issue Feb 11, 2022
@JJ-8
Copy link
Collaborator

JJ-8 commented Apr 22, 2022

Closing since #148 is merged

@JJ-8 JJ-8 closed this as completed Apr 22, 2022
JJ-8 added a commit that referenced this issue Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants