Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inline screenshots for each data set into the report #145

Closed
mgehlen opened this issue Oct 15, 2015 · 5 comments
Closed

add inline screenshots for each data set into the report #145

mgehlen opened this issue Oct 15, 2015 · 5 comments

Comments

@mgehlen
Copy link

mgehlen commented Oct 15, 2015

Hi,

I combine testNG data sets with screenshots added to the reports, for more details on my screenshoting you can see another issue: #144 .

I figured that I can add screenshots inline to the report, which I want to use. When I combine this with testNG data providers I get the following result:

  • data provider with 4 data sets
  • screenshot for first data set is added twice
  • screenshots for the other data sets are not shown

Is it somehow possible to add the screenshots for all data sets inline?

Thank you very much.

@janschaefer
Copy link
Contributor

Pretty much sounds like a bug. Thanks for reporting!

@janschaefer
Copy link
Contributor

One question: are you executing the cases in parallel?

@mgehlen
Copy link
Author

mgehlen commented Oct 15, 2015

thanks for the quick reply - I am not running tests in parallel at the moment.

@janschaefer
Copy link
Contributor

Ok. Then it is at least no multi-threading issue.

@janschaefer
Copy link
Contributor

I tested the issue and it is now clear to me what the problem is. The main problem is that JGiven tries to generate a data table. In fact it should print each case separately.

janschaefer pushed a commit that referenced this issue Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants