Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments in Parameterized Scenarios (junit-dataprovider) #77

Closed
ivan-masich opened this issue Jun 15, 2015 · 8 comments
Closed

Attachments in Parameterized Scenarios (junit-dataprovider) #77

ivan-masich opened this issue Jun 15, 2015 · 8 comments

Comments

@ivan-masich
Copy link
Contributor

Right now in the report I see attachments near steps only for first set of parameters, need possibility to show attachments for each parameter set.

Version: 0.7.2

@janschaefer
Copy link
Contributor

So you mean when you have a parameterized scenario with a data table at the bottom that shows the parameters of the different cases?
That is really a problem, you are right.
Do you have a proposal how this could be handled in the report?

@ivan-masich
Copy link
Contributor Author

Maybe by adding prefix to the title of attachment like "Parameter Set 1: Attachment Name". or maybe with text prefix before attachment icon.

@ivan-masich
Copy link
Contributor Author

Please look on possible fix for this problem #78.

@janschaefer
Copy link
Contributor

Cool thanks.

@janschaefer
Copy link
Contributor

Ok. I tried out your solution. While it works as expected, I think it is hard to see the relation to the different cases. I think it would be great if the attachments could appear in the data table next to the parameters. I will see whether I find a way of doing so.

@janschaefer
Copy link
Contributor

I slightly changed your solution to use smaller indices. What do you think?

@ivan-masich
Copy link
Contributor Author

With smaller indices looks better.

janschaefer pushed a commit that referenced this issue Jun 16, 2015
@janschaefer
Copy link
Contributor

Thanks. I then close the issue.

@janschaefer janschaefer added this to the v0.7.3 milestone Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants