From b4eaf72e4dcf3e00140dc520c8f3c6c96fcdc40e Mon Sep 17 00:00:00 2001 From: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com> Date: Fri, 21 Mar 2025 08:11:23 -0700 Subject: [PATCH 1/2] ui: improve missing library message --- src/tagstudio/qt/ts_qt.py | 12 +++++++++++- src/tagstudio/resources/translations/en.json | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/tagstudio/qt/ts_qt.py b/src/tagstudio/qt/ts_qt.py index da8931661..8b52808e5 100644 --- a/src/tagstudio/qt/ts_qt.py +++ b/src/tagstudio/qt/ts_qt.py @@ -1857,8 +1857,18 @@ def open_library(self, path: Path) -> None: open_status: LibraryStatus | None = None try: open_status = self.lib.open_library(path) + except ValueError as e: + logger.warning(e) + open_status = LibraryStatus( + success=False, + library_path=path, + message=Translations["menu.file.missing_library.title"], + msg_description=Translations.format( + "menu.file.missing_library.message", library=library_dir_display + ), + ) except Exception as e: - logger.exception(e) + logger.error(e) open_status = LibraryStatus( success=False, library_path=path, message=type(e).__name__, msg_description=str(e) ) diff --git a/src/tagstudio/resources/translations/en.json b/src/tagstudio/resources/translations/en.json index 6829e601b..1d9b5aa7f 100644 --- a/src/tagstudio/resources/translations/en.json +++ b/src/tagstudio/resources/translations/en.json @@ -197,6 +197,8 @@ "menu.edit": "Edit", "menu.file.clear_recent_libraries": "Clear Recent", "menu.file.close_library": "&Close Library", + "menu.file.missing_library.message": "The location of the library \"{library}\" cannot be found.", + "menu.file.missing_library.title": "Missing Library", "menu.file.new_library": "New Library", "menu.file.open_create_library": "&Open/Create Library", "menu.file.open_library": "Open Library", From aa993bfcc7e108a4ea8cabb07c10c66453bcb339 Mon Sep 17 00:00:00 2001 From: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com> Date: Fri, 21 Mar 2025 08:12:40 -0700 Subject: [PATCH 2/2] ui: update recent library max to 10 --- src/tagstudio/qt/ts_qt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tagstudio/qt/ts_qt.py b/src/tagstudio/qt/ts_qt.py index 8b52808e5..7703295d4 100644 --- a/src/tagstudio/qt/ts_qt.py +++ b/src/tagstudio/qt/ts_qt.py @@ -1728,7 +1728,7 @@ def remove_recent_library(self, item_key: str): def update_libs_list(self, path: Path | str): """Add library to list in SettingItems.LIBS_LIST.""" - item_limit: int = 5 + item_limit: int = 10 path = Path(path) self.settings.beginGroup(SettingItems.LIBS_LIST)