Skip to content

Conversation

@Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented May 16, 2025

Summary

Splits the View aspects out of QtDriver into the existing Main Window class so that only the Control aspects remain.
This will reduce the size of ts_qt.py and should generally make the code more maintainable.

Note: This is based off of #933 as that PR also modifies ts_qt.py and merging afterwards would be a pain.
(which also means that atm the #933 commits show up in this PR as well)

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@Computerdores Computerdores added Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request Type: Refactor Code that needs to be restructured or cleaned up labels May 16, 2025
@Computerdores Computerdores moved this to 🚧 In progress in TagStudio Development May 16, 2025
@CyanVoxel CyanVoxel changed the base branch from Alpha-v9.5.3 to main June 4, 2025 09:24
@CyanVoxel CyanVoxel removed the Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 4, 2025
@Computerdores Computerdores marked this pull request as ready for review June 4, 2025 18:44
@Computerdores
Copy link
Collaborator Author

Computerdores commented Jun 4, 2025

I was going to continue here, but it has been a while and this is already quite big, so I am putting this up for review as is.

If this rots for too long because of its size, I am fine with just closing it and maybe using it as a inspiration for smaller, future refactors that are easier to review

@Computerdores Computerdores added the Status: Review Needed A review of this is needed label Jun 4, 2025
@Computerdores Computerdores moved this from 🚧 In progress to 🏓 Ready for Review in TagStudio Development Jun 4, 2025
@CyanVoxel
Copy link
Member

Everything seems to function here, I think this would be good to pull as-is as long as the conflicts are cleaned up. It seems that there's a couple larger conflicts in ts_qt.py but other than that is just small leftovers from #933 and such. Since it's been a while if you'd rather not jump back into this I can take a look at untangling the conflicts and getting this merged

@CyanVoxel CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Jun 5, 2025
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Jun 5, 2025
@Computerdores Computerdores force-pushed the refactor/qtdriver_split branch from 8184378 to aaa226e Compare June 5, 2025 22:33
@Computerdores
Copy link
Collaborator Author

apologies for the force push, but that was required since the commits from #933 were squashed which meant that a rebase was required to remove them from this branch

@CyanVoxel CyanVoxel moved this from 👀 In review to 🍃 Pending Merge in TagStudio Development Jun 5, 2025
@CyanVoxel CyanVoxel added the Status: Mergeable The code is ready to be merged label Jun 5, 2025
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this! Any breaking up of ts_qt.py is always lovely to see

@CyanVoxel CyanVoxel merged commit 14d1c2b into TagStudioDev:main Jun 5, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from 🍃 Pending Merge to ✅ Done in TagStudio Development Jun 5, 2025
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Jun 6, 2025
@Computerdores Computerdores deleted the refactor/qtdriver_split branch July 6, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Refactor Code that needs to be restructured or cleaned up

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants