-
-
Notifications
You must be signed in to change notification settings - Fork 420
refactor: split QtDriver into View and Controller to follow MVC model #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split QtDriver into View and Controller to follow MVC model #935
Conversation
|
I was going to continue here, but it has been a while and this is already quite big, so I am putting this up for review as is. If this rots for too long because of its size, I am fine with just closing it and maybe using it as a inspiration for smaller, future refactors that are easier to review |
|
Everything seems to function here, I think this would be good to pull as-is as long as the conflicts are cleaned up. It seems that there's a couple larger conflicts in |
8184378 to
aaa226e
Compare
|
apologies for the force push, but that was required since the commits from #933 were squashed which meant that a rebase was required to remove them from this branch |
CyanVoxel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this! Any breaking up of ts_qt.py is always lovely to see
Summary
Splits the View aspects out of
QtDriverinto the existing Main Window class so that only the Control aspects remain.This will reduce the size of
ts_qt.pyand should generally make the code more maintainable.Note: This is based off of #933 as that PR also modifies
ts_qt.pyand merging afterwards would be a pain.(which also means that atm the #933 commits show up in this PR as well)
Tasks Completed