I'm doubtful about app_context

[ccoVeille]

You are embedding a context which is an anti pattern.

Here is the containedctx linter available in golangci-lint

https://github.com/sivchari/containedctx

You can look at the blog post it mentions.

As you are only using ctx.WithValue

I would expect your code to do not define AppContext, and add method to it, but define your app signatures like this

func GetUserID(ctx context.Context) (string, bool)

func SetUserID(ctx context. Context, userID string) context. Context

instead of

func (sc *AppContext) UserID() (string, bool) 

func (sc *AppContext) SetUserID(userID string) AppContext

[Talento90]

Thank you so much for looking into the project. The idea is to be a simple wrapper around the native context but ensure it uses the same Keys to access specific values. I will read this article: https://go.dev/blog/context-and-structs and see if it's worth refactoring to have static methods that receive the context and internally use the key.

[ccoVeille]

One solution could be to use this

type AppContext context.Context

So an alias and not a struct.

Your code would be almost the same.

Also, you should consider context as being immutable the alias will somehow force you to keep it immutable

[Talento90]

@ccoVeille I have been playing around with the appcontext package. I have seen in some projects people wrapping around the native context like the chi framework.

What do you think about the following changes:

• rename apperror.AppError to apperror.Error
• rename appcontext.AppContext to appcontext.Context
• use the composition pattern with the native appcontext.Context

Changes: #5