-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-form): support Remix SSR #1017
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a34c8a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 91.55% 86.30% -5.25%
==========================================
Files 21 28 +7
Lines 900 1110 +210
Branches 206 278 +72
==========================================
+ Hits 824 958 +134
- Misses 71 140 +69
- Partials 5 12 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is awesome! Thank you!
Closes #759
This PR adds support for Remix by copying the Nextjs adaptor which also works for Remix. An example and docs have also been added.