Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-form): support Remix SSR #1017

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

a-is-4-adam
Copy link
Contributor

Closes #759

This PR adds support for Remix by copying the Nextjs adaptor which also works for Remix. An example and docs have also been added.

Copy link

nx-cloud bot commented Nov 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a34c8a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@1017

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@1017

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@1017

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@1017

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@1017

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@1017

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@1017

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@1017

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@1017

commit: a34c8a0

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 86.30%. Comparing base (5473bb8) to head (a34c8a0).
Report is 160 commits behind head on main.

Files with missing lines Patch % Lines
...kages/react-form/src/remix/createServerValidate.ts 0.00% 20 Missing and 3 partials ⚠️
packages/react-form/src/remix/error.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   91.55%   86.30%   -5.25%     
==========================================
  Files          21       28       +7     
  Lines         900     1110     +210     
  Branches      206      278      +72     
==========================================
+ Hits          824      958     +134     
- Misses         71      140      +69     
- Partials        5       12       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Balastrong Balastrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome! Thank you!

@Balastrong Balastrong merged commit 56d065a into TanStack:main Nov 16, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Get SSR working with Remix
2 participants