Skip to content

fix(react-router): fix transitions #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schiller-manuel merged 2 commits into from
Dec 9, 2024
Merged

fix(react-router): fix transitions #2969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df3a78d
fix(react-router): fix transitions
schiller-manuel Dec 9, 2024
1dde753
ci: apply automated fixes
autofix-ci[bot] Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/react-router/src/Transitioner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function Transitioner() {
select: ({ isLoading }) => isLoading,
})

const [isTransitioning, startReactTransition_] = React.useTransition()
const [isTransitioning, setIsTransitioning] = React.useState(false)
// Track pending state changes
const hasPendingMatches = useRouterState({
select: (s) => s.matches.some((d) => d.status === 'pending'),
Expand All @@ -27,7 +27,13 @@ export function Transitioner() {
const previousIsPagePending = usePrevious(isPagePending)

if (!router.isServer) {
router.startReactTransition = startReactTransition_
router.startReactTransition = (fn: () => void) => {
setIsTransitioning(true)
React.startTransition(() => {
fn()
setIsTransitioning(false)
})
}
}

// Subscribe to location changes
Expand Down
Loading