Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit positional bool #293

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Prohibit positional bool #293

merged 1 commit into from
Dec 5, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

@CreepySkeleton CreepySkeleton commented Dec 2, 2019

Closes #212

cc @TeXitoi please also take a look at #292

@CreepySkeleton CreepySkeleton force-pushed the docs branch 2 times, most recently from 3b6acb4 to 4a28be1 Compare December 2, 2019 22:47
@therealprof
Copy link

The example is good, the "documentation" does not help a bit.

@CreepySkeleton
Copy link
Collaborator Author

CreepySkeleton commented Dec 2, 2019

@therealprof The doc is to address #287 , your case is covered by the example.

@therealprof
Copy link

Well, it didn't say that on the label, maybe you should throw in a "Closes #287" then?

@CreepySkeleton
Copy link
Collaborator Author

CreepySkeleton commented Dec 3, 2019

@therealprof
#287 is not an issue but PR, take look at the first comment there for detailed information.
I included it in this PR because "see this for example" link refers to examples/true_or_false.rs which is yet to be added by this PR.

@CreepySkeleton
Copy link
Collaborator Author

The example is good, the "documentation" does not help a bit.

Also, @therealprof , if you have some idea about how to address your case in the doc I'm all ears.

@CreepySkeleton CreepySkeleton changed the title Add "true" or "false" example Prohibit positional bool Dec 5, 2019
@CreepySkeleton
Copy link
Collaborator Author

CreepySkeleton commented Dec 5, 2019

@therealprof

I would like to apologize for being too blunt. I'm not really a "public relations" man, I take strait approach when explaining thinks to others, too strait sometimes. It was never my intention to offend you or discard your opinion, sorry if I left wrong impression.

But I'm not making amends, I mean every word I said. I still believe you case is a corner one, true/false arguments are common for config files indeed, but I have yet to meet a case when I would need to actually use them on command line. Even more, I wasn't even aware of existence of such applications until after you'd brought some examples.

We can't bring every corner case to README (and it's not an actual documentation anyway), hence I'm closing your PR. Do you think this PR provides adequate explanation?

@TeXitoi could use a review

Copy link
Owner

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

examples/true_or_false.rs Show resolved Hide resolved
examples/true_or_false.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@therealprof
Copy link

@CreepySkeleton No worries, all good here.

examples/true_or_false.rs Show resolved Hide resolved
@TeXitoi TeXitoi merged commit 8869d2f into master Dec 5, 2019
@CreepySkeleton CreepySkeleton deleted the docs branch December 5, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird bool behaviour when not defined as a flag parameter
3 participants