-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prohibit positional bool #293
Conversation
3b6acb4
to
4a28be1
Compare
The example is good, the "documentation" does not help a bit. |
@therealprof The doc is to address #287 , your case is covered by the example. |
Well, it didn't say that on the label, maybe you should throw in a "Closes #287" then? |
@therealprof |
Also, @therealprof , if you have some idea about how to address your case in the doc I'm all ears. |
I would like to apologize for being too blunt. I'm not really a "public relations" man, I take strait approach when explaining thinks to others, too strait sometimes. It was never my intention to offend you or discard your opinion, sorry if I left wrong impression. But I'm not making amends, I mean every word I said. I still believe you case is a corner one, We can't bring every corner case to README (and it's not an actual documentation anyway), hence I'm closing your PR. Do you think this PR provides adequate explanation? @TeXitoi could use a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
@CreepySkeleton No worries, all good here. |
Closes #212
cc @TeXitoi please also take a look at #292