Merge pull request ESCOMP#2355 from olyson/tsoisno272

Set initial t_soisno=272 for soils and 274K for urban road

cime_config/testdefs/ExpectedTestFails.xml

@@ -147,6 +147,13 @@
       <issue>#2310</issue>
     </phase>
   </test>
+
+  <test name="SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_intel.clm-FatesColdHydro">
+    <phase name="RUN">
+      <status>FAIL</status>
+      <issue>#2373</issue>
+    </phase>
+  </test>
 
   <!-- fates test suite failures -->
 

doc/ChangeLog

@@ -1,4 +1,74 @@
 ===============================================================
+Tag name: ctsm5.1.dev171
+Originator(s): olyson (Keith Oleson,UCAR/TSS)
+Date: Mon 04 Mar 2024 10:33:55 AM MST
+One-line Summary: Set initial t_soisno=272 for soils and 274K for urban road
+
+Purpose and description of changes
+----------------------------------
+
+ Issue #2338 and PR #2355 explain:
+ Soil temperature initialization not implemented correctly in
+ ctsm5.1.dev058 and thus subsequent tags.
+
+Significant changes to scientifically-supported configurations
+--------------------------------------------------------------
+
+Does this tag change answers significantly for any of the following physics configurations?
+(Details of any changes will be given in the "Answer changes" section below.)
+
+    [Put an [X] in the box for any configuration with significant answer changes.]
+
+[ ] clm5_1
+
+[ ] clm5_0
+
+[ ] ctsm5_0-nwp
+
+[ ] clm4_5
+
+
+Bugs fixed
+----------
+CTSM issues fixed (include CTSM Issue #):
+ Fixes #2338
+
+Notes of particular relevance for developers:
+---------------------------------------------
+Changes to tests or testing:
+ SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_intel.clm-FatesColdHydro
+ added to expected failures, issue #2373, to be revisited when #2384 is
+ resolved.
+
+Testing summary:
+----------------
+ [PASS means all tests PASS; OK means tests PASS other than expected fails.]
+
+  regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):
+
+    derecho ----- OK
+    izumi ------- OK
+
+Answer changes
+--------------
+
+Changes answers relative to baseline: YES
+
+  Summarize any changes to answers, i.e.,
+    - what code configurations: all
+    - what platforms/compilers: all
+    - nature of change: larger than roundoff but not climate-changing
+
+ The original diagnostics for this change are here:
+ https://webext.cgd.ucar.edu/I2000/ctsm51c6_PPEn08ctsm51d023_2deg_GSWP3V1_Sparse400_cs_ts_tsoisno272_2000AD/lnd/ctsm51c6_PPEn08ctsm51d023_2deg_GSWP3V1_Sparse400_cs_ts_tsoisno272_2000AD.381_400-ctsm51c6_PPEn08ctsm51d023_2deg_GSWP3V1_Sparse400_cs_ts_2000AD.381_400/setsIndex.html
+
+Other details
+-------------
+Pull Requests that document the changes (include PR ids):
+ https://github.com/ESCOMP/ctsm/pull/2355
+
+===============================================================
+===============================================================
 Tag name: ctsm5.1.dev170
 Originator(s): samrabin (Sam Rabin, UCAR/TSS, samrabin@ucar.edu)
 Date: Wed Feb 28 11:01:43 MST 2024

doc/ChangeSum

@@ -1,5 +1,6 @@
 Tag                   Who      Date  Summary
 ============================================================================================================================
+    ctsm5.1.dev171   slevis 03/01/2024 Set initial t_soisno=272 for soils and 274K for urban road
     ctsm5.1.dev170 samrabin 02/28/2024 Add hillslope hydrology
     ctsm5.1.dev169 samrabin 02/22/2024 Merge b4b-dev
     ctsm5.1.dev168   slevis 02/16/2024 Remove a source of negative snocan in CanopyFluxesMod

src/biogeophys/TemperatureType.F90

@@ -732,7 +732,7 @@ subroutine InitCold(this, bounds, &
                   end if
                else
                   if (col%itype(c) == icol_road_perv .or. col%itype(c) == icol_road_imperv) then
-                     this%t_soisno_col(c,1:nlevgrnd) = 272._r8
+                     this%t_soisno_col(c,1:nlevgrnd) = 274._r8
                   else if (col%itype(c) == icol_sunwall .or. col%itype(c) == icol_shadewall &
                        .or. col%itype(c) == icol_roof) then
                      ! Set sunwall, shadewall, roof to fairly high temperature to avoid initialization
@@ -741,7 +741,7 @@ subroutine InitCold(this, bounds, &
                   end if
                end if
             else
-               this%t_soisno_col(c,1:nlevgrnd) = 274._r8
+               this%t_soisno_col(c,1:nlevgrnd) = 272._r8
                if (use_excess_ice .and. (lun%itype(l) == istsoil .or. lun%itype(l) == istcrop)) then
                   this%t_soisno_col(c,1:nlevgrnd) = SHR_CONST_TKFRZ - 5.0_r8 !needs to be below freezing to properly initiate excess ice
                end if