Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an NPE when sorting a null search results list #3181

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1465,9 +1465,10 @@ public void addSearchResult(HybridFileParcelable a, String query) {
}

public void onSearchCompleted(final String query) {
final ArrayList<LayoutElementParcelable> elements = mainFragmentViewModel.getListElements();
final @Nullable ArrayList<LayoutElementParcelable> elements = mainFragmentViewModel.getListElements();
if (elements == null) {
Log.e(TAG, "No search results, cannot sort!");
return;
}
if (!mainFragmentViewModel.getResults()) {
// no results were found
Expand Down