Bugfix/status bar color #3241
Merged
Bugfix/status bar color #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please work on the code analysis failure, you can run. |
EmmanuelMess
reviewed
Apr 2, 2022
| @@ -112,6 +113,14 @@ public void initStatusBarResources(View parentView) { | |||
|
|
|||
| if (getBoolean(PREFERENCE_COLORED_NAVIGATION) && SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { | |||
There was a problem hiding this comment.
This should be:
if (SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
if (getBoolean(PREFERENCE_COLORED_NAVIGATION)) {
window.setNavigationBarColor(PreferenceUtils.getStatusColor(getPrimary()));
} else {
if (getAppTheme().equals(AppTheme.LIGHT)) {
window.setNavigationBarColor(Utils.getColor(this, android.R.color.white));
} else if (getAppTheme().equals(AppTheme.BLACK)) {
window.setNavigationBarColor(Utils.getColor(this, android.R.color.black));
} else {
window.setNavigationBarColor(Utils.getColor(this, R.color.holo_dark_background));
}
}
}
EmmanuelMess
reviewed
Apr 2, 2022
| setTheme(R.style.aboutBlack); | ||
| } else { | ||
| setTheme(R.style.aboutLight); | ||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) { |
There was a problem hiding this comment.
And for versions older that lollipop?
There was a problem hiding this comment.
I have checked the official documentation and found that the color of the navigation bar cannot be manipulated for sdk versions before Lollipop, the closest you can get is making the bar translucent
DoozyDoz
commented
Apr 4, 2022
| @@ -105,23 +105,22 @@ public void initStatusBarResources(View parentView) { | |||
| } else { | |||
| window.addFlags(WindowManager.LayoutParams.FLAG_TRANSLUCENT_STATUS); | |||
| } | |||
| if (getBoolean(PREFERENCE_COLORED_NAVIGATION)) { | |||
There was a problem hiding this comment.
@EmmanuelMess I have transfered the code to the right block as requested hope its fine now
VishalNehra
approved these changes
Apr 23, 2022
|
Thanks for contribution. Sorry that it took some time to review. Changeset looks fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to the issue reported in #3234:
Colorize Navigation Barinsettings -> Apperancethe navigation bar turns black no matter the current theme.Issue tracker
Addresses issue at #3234
Colorize Navigation Baris ticked in settings, navigation bar color is consistent with primary color(blue) in all activities.Colorize Navigation Baris unticked in settings, navigation bar color always follows the current theme.Automatic tests
Manual tests
Done
Device: Huawei p30 lite
OS: Android 10
Device: Sharp Aquos 803SH
OS: Android 10
Device: Redmi Note 7
OS: Android 10
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck