Exception handling for 7z entries without timestamps #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3035. For 7z archives having entries with no timestamp, - they will show as 00:00:00 1970-01-01 when in file manager view - they will have last modified date = current timestamp on extracting
TranceLove
added
Issue-Bug
VishalNehra
previously approved these changes
Apr 16, 2022
EmmanuelMess
requested changes
Apr 22, 2022
...ava/com/amaze/filemanager/filesystem/compressed/extractcontents/helpers/SevenZipExtractor.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/amaze/filemanager/asynchronous/asynctasks/compress/SevenZipHelperCallable.kt
Outdated
Show resolved
Hide resolved
VishalNehra
approved these changes
Apr 23, 2022
| val lastModifiedDate = try { | ||
| entry.lastModifiedDate.time | ||
| } catch (e: UnsupportedOperationException) { | ||
| Log.w(javaClass.simpleName, "Unable to get modified date for 7zip file") |
There was a problem hiding this comment.
These should use TAG why was this fixed like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems such archives can be created intentionally.
For 7z archives having entries with no timestamp,
Description
Issue tracker
Fixes #3035
Automatic tests
Manual tests
Done
Device: Pixel 2 emulator
OS: Android 11
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck