Fix SSHConnectionPool with subdirectories in URI #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow sharing connections having the same connection credentials and host, but with different paths. Also fixes problem that thumbnails on SSH servers cannot be generated.
TranceLove
added
Issue-Bug
EmmanuelMess
approved these changes
Apr 23, 2022
VishalNehra
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to allow sharing connections having the same connection credentials and host, but with different paths. Also fixes problem that thumbnails on SSH servers cannot be generated due to failure on loading remote file.
Automatic tests
Manual tests
Done
Device: Pixel 2 emulator
OS: Android 11
Image thumbnails should load with SSH connections setup with default path provided.
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck