Fix columns for grid layout for MainFragment #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelMess
force-pushed
the
emmanuelmess/fix/columns_preference
branch
2 times, most recently
from
a1f94c0
to
46241fc
Compare
EmmanuelMess
force-pushed
the
emmanuelmess/fix/columns_preference
branch
from
46241fc
to
d2dda03
Compare
EmmanuelMess
requested review from
VishalNehra,
TranceLove and
VishnuSanal
and removed request for
VishalNehra
VishalNehra
approved these changes
Apr 24, 2022
4 tasks
VishnuSanal
reviewed
Apr 25, 2022
There was a problem hiding this comment.
@EmmanuelMess Please see the comments - a simple clarification.
app/src/main/java/com/amaze/filemanager/ui/fragments/data/MainFragmentViewModel.kt
Show resolved
Hide resolved
...main/java/com/amaze/filemanager/ui/fragments/preference_fragments/AppearancePrefsFragment.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks how defaults are handled for grid columns preference and fixes a divide by zero crash.
Issue tracker
Fixes #3249
Automatic tests
Manual tests
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck